[pve-devel] [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS

[Filip Schauer <f.schauer@proxmox.com>]

This patch series prevents starting a 32-bit VM using a 64-bit OVMF BIOS
and makes the default value for 'kvm' during CPU hotplug consistent with
the rest of the code. This is a breaking change for VMs with a different
CPU architecture running on an x86_64 host.

Changes since v7:
* Rename is_native to is_native_arch to be more explicit
* Move get_default_cpu_type from Helpers to CPUConfig
* Default to host architecture when no $arch is given to get_cpu_bitness
* die with a message on hotplug of non x86_64 CPUs in print_cpu_device

Changes since v6:
* Skip the CPU bitness check if $forcecpu is set
* Take custom CPU types into account
* Add a helper for getting the default CPU type
* Unify the default value for 'kvm'
* Move is_native from PVE::QemuServer to PVE::Tools

Changes since v5:
* Refactor get_cpu_bitness to die instead of returning undef
* Pass cputype instead of the entire vm config to get_cpu_bitness

Changes since v4:
* Remove parentheses around post-if in get_cpu_bitness

Changes since v3:
* Move the cputypes_32bit list from QemuServer.pm to CPUConfig.pm
* Turn cputypes_32bit into a hash for lookup
* Create a helper get_cpu_bitness function in CPUConfig.pm
* Describe how the list of 32-bit CPU types was obtained

common:

Filip Schauer (1):
  tools: add is_native_arch to compare the CPU architecture

 src/PVE/Tools.pm | 6 ++++++
 1 file changed, 6 insertions(+)

qemu-server:

Filip Schauer (5):
  cpu config: Add helper to get the default CPU type
  Prevent starting a 32-bit VM using a 64-bit OVMF BIOS
  Move is_native from PVE::QemuServer to PVE::Tools
  Unify the default value for 'kvm'
  cpu config: die on hotplug of non x86_64 CPUs

 PVE/QemuServer.pm           | 23 +++++++------
 PVE/QemuServer/CPUConfig.pm | 64 ++++++++++++++++++++++++++++++++-----
 2 files changed, 67 insertions(+), 20 deletions(-)

-- 
2.39.2