all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation
Date: Thu, 15 Feb 2024 13:39:33 +0100	[thread overview]
Message-ID: <20240215124004.1197676-1-c.heiss@proxmox.com> (raw)

This series improves various aspects regarding FQDN handling and
validation across both the GUI and TUI installer.

It (partially) addresses issue #5230 [0] in patch #5, by fixing the
regex through which we validate FQDNs in the GUI installer.

It also refactors the FQDN validation/parsing in the GUI installer, by
moving it into its own subroutine - making the whole thing bit easier to
reason about, as well as adding loads of test cases.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=5230

Christoph Heiss (5):
  common: fqdn: do not allow overlong FQDNs as per Debian spec
  common: fqdn: implement case-insensitive comparison as per RFC 952
  proxinstall: avoid open-coding FQDN sanity check
  sys: net: do not allow overlong FQDNs as per RFCs and Debian spec
  fix #5230: sys: net: properly escape FQDN regex

 Proxmox/Sys/Net.pm                    | 29 +++++++++-
 proxinstall                           | 22 +++-----
 proxmox-installer-common/src/utils.rs | 79 ++++++++++++++++++++++++++-
 test/Makefile                         |  6 +-
 test/parse-fqdn.pl                    | 57 +++++++++++++++++++
 5 files changed, 172 insertions(+), 21 deletions(-)
 create mode 100755 test/parse-fqdn.pl

--
2.43.0





             reply	other threads:[~2024-02-15 12:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 12:39 Christoph Heiss [this message]
2024-02-15 12:39 ` [pve-devel] [PATCH installer 1/5] common: fqdn: do not allow overlong FQDNs as per Debian spec Christoph Heiss
2024-02-15 12:39 ` [pve-devel] [PATCH installer 2/5] common: fqdn: implement case-insensitive comparison as per RFC 952 Christoph Heiss
2024-02-23 16:10   ` Thomas Lamprecht
2024-02-15 12:39 ` [pve-devel] [PATCH installer 3/5] proxinstall: avoid open-coding FQDN sanity check Christoph Heiss
2024-02-15 12:39 ` [pve-devel] [PATCH installer 4/5] sys: net: do not allow overlong FQDNs as per RFCs and Debian spec Christoph Heiss
2024-02-15 12:39 ` [pve-devel] [PATCH installer 5/5] fix #5230: sys: net: properly escape FQDN regex Christoph Heiss
2024-02-23 16:27   ` Thomas Lamprecht
2024-02-26  9:04     ` Christoph Heiss
2024-02-23 16:31 ` [pve-devel] applied-series: [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240215124004.1197676-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal