From: Stefan Lendl <s.lendl@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v3 proxmox-backup 8/8] gc: configure width and flex on GC Jobs columns
Date: Thu, 8 Feb 2024 14:59:49 +0100 [thread overview]
Message-ID: <20240208135953.2078165-9-s.lendl@proxmox.com> (raw)
In-Reply-To: <20240208135953.2078165-1-s.lendl@proxmox.com>
table expands to the full width and relevant data is still visible on a
narrow screen.
Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>
Reviewd-by: Gabriel Goller <g.goller@proxmox.com>
---
www/config/GCView.js | 30 +++++++++++++++++++-----------
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/www/config/GCView.js b/www/config/GCView.js
index d1f1bf71..0e49a0ac 100644
--- a/www/config/GCView.js
+++ b/www/config/GCView.js
@@ -159,63 +159,71 @@ Ext.define('PBS.config.GCJobView', {
header: gettext('Datastore'),
dataIndex: 'store',
renderer: Ext.String.htmlEncode,
- width: 120,
sortable: true,
hideable: false,
+ width: 150,
+ minWidth: 120,
+ maxWidth: 300,
+ flex: 2,
},
{
header: gettext('Schedule'),
dataIndex: 'schedule',
- maxWidth: 220,
- minWidth: 80,
- flex: 1,
sortable: false,
hideable: false,
renderer: (value) => value ? value : Proxmox.Utils.NoneText,
+ width: 85,
+ minWidth: 85,
+ flex: 1,
},
{
header: gettext('Last GC'),
dataIndex: 'last-run-endtime',
renderer: PBS.Utils.render_optional_timestamp,
- minWidth: 150,
sortable: true,
+ minWidth: 150,
+ flex: 1,
},
{
text: gettext('Duration'),
dataIndex: 'duration',
renderer: Proxmox.Utils.render_duration,
sortable: false,
- width: 80,
+ minWidth: 80,
+ flex: 1,
},
{
header: gettext('Last Status'),
dataIndex: 'last-run-state',
renderer: PBS.Utils.render_task_status,
sortable: true,
- flex: 3,
- maxWidth: 100,
+ width: 100,
minWidth: 80,
+ flex: 1,
},
{
header: gettext('Next Run'),
dataIndex: 'next-run',
renderer: PBS.Utils.render_next_task_run,
- width: 150,
sortable: true,
+ minWidth: 150,
+ flex: 1,
},
{
header: gettext('Removed Chunks'),
dataIndex: 'removed-chunks',
renderer: (value) => value !== undefined ? value : "-",
- maxWidth: 100,
sortable: false,
+ minWidth: 85,
+ flex: 1,
},
{
header: gettext('Pending Chunks'),
dataIndex: 'pending-chunks',
renderer: (value) => value !== undefined ? value : "-",
- maxWidth: 100,
sortable: false,
+ minWidth: 80,
+ flex: 3,
},
],
--
2.43.0
next prev parent reply other threads:[~2024-02-08 14:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 13:59 [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE *** Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-03-21 10:23 ` Lukas Wagner
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 2/8] gc: global prune and gc job view Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 3/8] gc: move datastore/PruneAndGC to config/PruneAndGC Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 4/8] gc: hide datastore column in local gc view Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 5/8] ui: order Prune&GC before SyncJobs Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 6/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 7/8] gc: show removed and pending chunks of last run in ui Stefan Lendl
2024-02-08 13:59 ` Stefan Lendl [this message]
2024-02-21 9:56 ` [pbs-devel] [PATCH v3 proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-02-21 9:58 ` Stefan Lendl
2024-03-07 13:16 ` Stefan Lendl
2024-03-21 10:24 ` [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE *** Lukas Wagner
2024-04-04 13:53 ` Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208135953.2078165-9-s.lendl@proxmox.com \
--to=s.lendl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.