From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 storage] plugin schema: improve description of 'shared' property
Date: Tue, 30 Jan 2024 11:28:31 +0100 [thread overview]
Message-ID: <20240130102831.19846-1-f.ebner@proxmox.com> (raw)
It's not clear to users what this property does otherwise. Latest
report from the community forum:
https://forum.proxmox.com/threads/134393
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Changes in v2:
* improve wording based on Fabian's suggestions, thanks!
@Fabian: I didn't want to drop the "single" and I felt like the "on
all nodes that can access it" might leave some users thinking when
there's nothing to think about: the storage has to be accessible from
all nodes (or all configured 'nodes'). "It will not automatically make
a local storage shared" also didn't feel super helpful while we're
still trying to explain what "shared" means.
I'll send a patch for pve-docs once the wording is accepted.
src/PVE/Storage/Plugin.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index fbbf491..e086de9 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -170,7 +170,10 @@ my $defaultData = {
default => "Unlimited for users with Datastore.Allocate privilege, 5 for other users",
},
shared => {
- description => "Mark storage as shared.",
+ description => "Indicate that this is a single storage with the same contents on all "
+ ."nodes (or all listed in the 'nodes' option). It will not make the contents of a "
+ ."local storage automatically accessible to other nodes, it just marks an already "
+ ."shared storage as such!",
type => 'boolean',
optional => 1,
},
--
2.39.2
next reply other threads:[~2024-01-30 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:28 Fiona Ebner [this message]
2024-01-30 11:43 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130102831.19846-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.