* [pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement
@ 2024-01-29 9:47 Alexander Zeidler
2024-02-02 18:17 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Zeidler @ 2024-01-29 9:47 UTC (permalink / raw)
To: pve-devel
to avoid a failing null check and its error message. This confused
users since the activation was successful anyway.
Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
v2:
* use "return" instead of "return undef"
* add commit message
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061280.html
PVE/CLI/pvesubscription.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/pvesubscription.pm b/PVE/CLI/pvesubscription.pm
index efd4ada4..51f5b71e 100755
--- a/PVE/CLI/pvesubscription.pm
+++ b/PVE/CLI/pvesubscription.pm
@@ -48,6 +48,8 @@ __PACKAGE__->register_method({
PVE::API2::Subscription::check_key($info->{key}, PVE::API2::Subscription::get_sockets());
PVE::API2::Subscription::write_etc_subscription($info);
+
+ return;
}});
our $cmddef = {
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH v2 manager] pvesubscription: add missing return statement
2024-01-29 9:47 [pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement Alexander Zeidler
@ 2024-02-02 18:17 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-02-02 18:17 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexander Zeidler
Am 29/01/2024 um 10:47 schrieb Alexander Zeidler:
> to avoid a failing null check and its error message. This confused
> users since the activation was successful anyway.
>
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> v2:
> * use "return" instead of "return undef"
> * add commit message
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061280.html
>
> PVE/CLI/pvesubscription.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-02 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-29 9:47 [pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement Alexander Zeidler
2024-02-02 18:17 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal