From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] fix #5074: notify: sendmail: smtp: fix mailto/mailto-user parameter deletion
Date: Thu, 4 Jan 2024 13:38:47 +0100 [thread overview]
Message-ID: <20240104123847.29087-1-f.ebner@proxmox.com> (raw)
by doing a cbind of isCreate to the top-level widget so that cbind in
the nested widgets for deleteEmpty works.
In the GUI, when a sendmail/smtp target is edited and either
'Additional Recipients' or 'Recipients' is completely removed (only
possible if the other field contains a value), parameter deletion did
not work properly. After applying the changes, the old value would
still be in place.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/panel/EmailRecipientPanel.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/panel/EmailRecipientPanel.js b/src/panel/EmailRecipientPanel.js
index b2bc03c..da64f45 100644
--- a/src/panel/EmailRecipientPanel.js
+++ b/src/panel/EmailRecipientPanel.js
@@ -19,6 +19,9 @@ Ext.define('Proxmox.panel.EmailRecipientPanel', {
{
layout: 'anchor',
border: false,
+ cbind: {
+ isCreate: '{isCreate}',
+ },
items: [
{
xtype: 'pmxUserSelector',
--
2.39.2
next reply other threads:[~2024-01-04 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 12:38 Fiona Ebner [this message]
2024-01-04 13:03 ` Lukas Wagner
2024-01-05 9:35 ` [pve-devel] applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104123847.29087-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal