[pve-devel] [PATCH widget-toolkit v2] i18n: mark strings as translatable

[pve-devel] [PATCH widget-toolkit v2] i18n: mark strings as translatable

[Maximiliano Sandoval]

Note that N/A is already translatable in other places.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
  - Translate the invalid subscription key message, this string is also in two more places in pve-manager. This will be the content of a following patch.
  - Do not translate 'ACME'

 src/Utils.js                          | 5 ++++-
 src/node/DNSView.js                   | 2 +-
 src/panel/DiskList.js                 | 6 +++---
 src/window/NotificationMatcherEdit.js | 2 +-
 4 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index 0a6d263..faef8e1 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -152,7 +152,10 @@ utilities: {
     },
 
     getNoSubKeyHtml: function(url) {
-	return Ext.String.format('You do not have a valid subscription for this server. Please visit <a target="_blank" href="{0}">www.proxmox.com</a> to get a list of available options.', url || 'https://www.proxmox.com');
+	let html_url = Ext.String.format('<a target="_blank" href="{0}">www.proxmox.com</a>', url || 'https://www.proxmox.com');
+	return Ext.String.format(
+	    gettext('You do not have a valid subscription for this server. Please visit {0} to get a list of available options.'),
+	    html_url);
     },
 
     format_boolean_with_default: function(value) {
diff --git a/src/node/DNSView.js b/src/node/DNSView.js
index 4782f9c..d2a784f 100644
--- a/src/node/DNSView.js
+++ b/src/node/DNSView.js
@@ -21,7 +21,7 @@ Ext.define('Proxmox.node.DNSView', {
 	    run_editor: run_editor,
 	    rows: {
 		search: {
-		    header: 'Search domain',
+		    header: gettext('Search domain'),
 		    required: true,
 		    renderer: Ext.htmlEncode,
 		},
diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
index 4808f5c..dc10ac5 100644
--- a/src/panel/DiskList.js
+++ b/src/panel/DiskList.js
@@ -325,14 +325,14 @@ Ext.define('Proxmox.DiskList', {
 	    dataIndex: 'status',
 	},
 	{
-	    header: 'Mounted',
+	    header: gettext('Mounted'),
 	    width: 60,
 	    align: 'right',
 	    renderer: Proxmox.Utils.format_boolean,
 	    dataIndex: 'mounted',
 	},
 	{
-	    header: 'Wearout',
+	    header: gettext('Wearout'),
 	    width: 90,
 	    sortable: true,
 	    align: 'right',
@@ -341,7 +341,7 @@ Ext.define('Proxmox.DiskList', {
 		if (Ext.isNumeric(value)) {
 		    return (100 - value).toString() + '%';
 		}
-		return 'N/A';
+		return gettext('N/A');
 	    },
 	},
     ],
diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
index f88576a..e717ad7 100644
--- a/src/window/NotificationMatcherEdit.js
+++ b/src/window/NotificationMatcherEdit.js
@@ -1025,7 +1025,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleSettings', {
 	    ],
 	},
 	{
-	    fieldLabel: 'Match Type',
+	    fieldLabel: gettext('Match Type'),
 	    xtype: 'proxmoxKVComboBox',
 	    reference: 'type',
 	    isFormField: false,
-- 
2.39.2

[pve-devel] applied: [PATCH widget-toolkit v2] i18n: mark strings as translatable

[Thomas Lamprecht]

Am 07/12/2023 um 09:18 schrieb Maximiliano Sandoval:
> Note that N/A is already translatable in other places.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v2:
>   - Translate the invalid subscription key message, this string is also in two more places in pve-manager. This will be the content of a following patch.
>   - Do not translate 'ACME'
> 
>  src/Utils.js                          | 5 ++++-
>  src/node/DNSView.js                   | 2 +-
>  src/panel/DiskList.js                 | 6 +++---
>  src/window/NotificationMatcherEdit.js | 2 +-
>  4 files changed, 9 insertions(+), 6 deletions(-)
> 
>

applied, thanks!