all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 0/4] add 'show information' for snapshots
Date: Tue,  5 Dec 2023 11:53:41 +0100	[thread overview]
Message-ID: <20231205105345.1656325-1-d.csapak@proxmox.com> (raw)

includes the upload statistics. This also moves some actions from the
column directly into a 'hamburger menu' so we don't overload the grid.

The only downside to this currently is that i could get keyboard
navigation to work for the context menu or the hamburger menu, but i'm
still looking into this.

changes from v1:
* renamed 'group-notes' to 'group-comment' to be consistent with the
  'comment' field
* added the (group)comment as tabs where the files lists are
* moved the files/comment tabpanel to the bottom
* made the window a bit wider, and put the upload statistics and
  verification info side by side, this way we save a bit vertical space
  (needed since the tabpanel takes a bit more)

continuation for the context menu series[0]
(changes title due to the context menu patch being applied)

0: https://lists.proxmox.com/pipermail/pbs-devel/2023-November/007248.html

Dominik Csapak (4):
  api-types: add an UploadStatistic api type
  api: datastore admin: add 'snapshot-information' api call
  ui: datastore content: add snapshot information to context menu
  ui: datastore content: add 'more actions' menu to actions

 pbs-api-types/src/datastore.rs |  40 +++++
 src/api2/admin/datastore.rs    | 117 ++++++++++++++-
 www/Makefile                   |   1 +
 www/datastore/Content.js       | 130 +++++++++++------
 www/window/SnapshotInfo.js     | 259 +++++++++++++++++++++++++++++++++
 5 files changed, 493 insertions(+), 54 deletions(-)
 create mode 100644 www/window/SnapshotInfo.js

-- 
2.30.2





             reply	other threads:[~2023-12-05 10:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 10:53 Dominik Csapak [this message]
2023-12-05 10:53 ` [pbs-devel] [PATCH proxmox-backup v2 1/4] api-types: add an UploadStatistic api type Dominik Csapak
2023-12-05 10:53 ` [pbs-devel] [PATCH proxmox-backup v2 2/4] api: datastore admin: add 'snapshot-information' api call Dominik Csapak
2023-12-05 10:53 ` [pbs-devel] [PATCH proxmox-backup v2 3/4] ui: datastore content: add snapshot information to context menu Dominik Csapak
2023-12-05 10:53 ` [pbs-devel] [PATCH proxmox-backup v2 4/4] ui: datastore content: add 'more actions' menu to actions Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231205105345.1656325-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal