* [pbs-devel] [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs'
@ 2023-11-30 8:49 Dominik Csapak
2023-11-30 9:05 ` Fiona Ebner
2023-11-30 9:18 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2023-11-30 8:49 UTC (permalink / raw)
To: pbs-devel
without any default value in the viewModel, the resulting url would be:
`<id>?destroy-data=<value>&keep-job-configs=`
which is missing the actual value, so add the default
Fixes: e9979a1a ("ui: add 'keep configs' checkbox to datastore removal window")
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/OptionView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 3ef4d3d5..6f1be969 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -10,6 +10,7 @@ Ext.define('PBS.window.SafeDatastoreDestroy', {
viewModel: {
data: {
'destroyData': 0,
+ 'keepJobConfigs': 0,
},
formulas: {
destroyNote: get => get('destroyData')
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pbs-devel] [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs'
2023-11-30 8:49 [pbs-devel] [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs' Dominik Csapak
@ 2023-11-30 9:05 ` Fiona Ebner
2023-11-30 9:18 ` [pbs-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2023-11-30 9:05 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
Am 30.11.23 um 09:49 schrieb Dominik Csapak:
> without any default value in the viewModel, the resulting url would be:
>
> `<id>?destroy-data=<value>&keep-job-configs=`
>
> which is missing the actual value, so add the default
>
> Fixes: e9979a1a ("ui: add 'keep configs' checkbox to datastore removal window")
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [pbs-devel] applied: [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs'
2023-11-30 8:49 [pbs-devel] [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs' Dominik Csapak
2023-11-30 9:05 ` Fiona Ebner
@ 2023-11-30 9:18 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-11-30 9:18 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
Am 30/11/2023 um 09:49 schrieb Dominik Csapak:
> without any default value in the viewModel, the resulting url would be:
>
> `<id>?destroy-data=<value>&keep-job-configs=`
>
> which is missing the actual value, so add the default
>
> Fixes: e9979a1a ("ui: add 'keep configs' checkbox to datastore removal window")
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/datastore/OptionView.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, with Fiona's T-b, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-30 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-30 8:49 [pbs-devel] [PATCH proxmox-backup] ui: fix deleting datastore without 'keep-job-configs' Dominik Csapak
2023-11-30 9:05 ` Fiona Ebner
2023-11-30 9:18 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal