From: Markus Frank <m.frank@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v3 6/6] tools: prohibit disk wipe of EFI partition
Date: Tue, 28 Nov 2023 14:23:23 +0100 [thread overview]
Message-ID: <20231128132323.162721-7-m.frank@proxmox.com> (raw)
In-Reply-To: <20231128132323.162721-1-m.frank@proxmox.com>
If the GUID is c12a7328-f81f-11d2-ba4b-00a0c93ec93b the partition is an
EFI Partition and should not be wiped.
Since this GUID is used multiple times, a constant for the EFI & BIOS
GUID is useful.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
src/tools/disks/mod.rs | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs
index beb8178b..0fe57d23 100644
--- a/src/tools/disks/mod.rs
+++ b/src/tools/disks/mod.rs
@@ -39,6 +39,9 @@ lazy_static::lazy_static! {
regex::Regex::new(r"host[^/]*/session[^/]*").unwrap();
}
+const EFI_PARTITION_TYPE: &str = "c12a7328-f81f-11d2-ba4b-00a0c93ec93b";
+const BIOS_PARTITION_TYPE: &str = "21686148-6449-6e6f-744e-656564454649";
+
/// Disk management context.
///
/// This provides access to disk information with some caching for faster querying of multiple
@@ -844,8 +847,8 @@ fn get_partitions_info(
if let (Some(devpath), Some(infos)) = (devpath.as_ref(), lsblk_infos.as_ref()) {
for info in infos.iter().filter(|i| i.path.eq(devpath)) {
used = match info.partition_type.as_deref() {
- Some("21686148-6449-6e6f-744e-656564454649") => PartitionUsageType::BIOS,
- Some("c12a7328-f81f-11d2-ba4b-00a0c93ec93b") => PartitionUsageType::EFI,
+ Some(BIOS_PARTITION_TYPE) => PartitionUsageType::BIOS,
+ Some(EFI_PARTITION_TYPE) => PartitionUsageType::EFI,
Some("6a945a3b-1dd2-11b2-99a6-080020736631") => {
PartitionUsageType::ZfsReserved
}
@@ -1080,6 +1083,12 @@ pub fn wipe_blockdev(disk: &Disk, worker: Arc<WorkerTask>) -> Result<(), Error>
for disk_info in get_lsblk_info()?.iter() {
if disk_info.path == disk_path_str && disk_info.partition_type.is_some() {
is_partition = true;
+ if matches!(
+ disk_info.partition_type.as_deref(),
+ Some(EFI_PARTITION_TYPE)
+ ) {
+ bail!("You will not be able to boot if you wipe the EFI partition.");
+ }
}
}
--
2.39.2
next prev parent reply other threads:[~2023-11-28 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 13:23 [pbs-devel] [PATCH proxmox-backup v3 0/6] fix #3690: wipe disk Markus Frank
2023-11-28 13:23 ` [pbs-devel] [PATCH proxmox-backup v3 1/6] fix #3690: pbs_api_types: add regex, format & schema for partition names to pbs-api-types Markus Frank
2023-11-28 17:41 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-28 13:23 ` [pbs-devel] [PATCH proxmox-backup v3 2/6] fix #3690: tools: add wipe_blockdev & change_parttype rust equivalent Markus Frank
2023-11-28 17:42 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-28 13:23 ` [pbs-devel] [PATCH proxmox-backup v3 3/6] fix #3690: api: add function wipe_disk Markus Frank
2023-11-28 17:42 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-28 13:23 ` [pbs-devel] [PATCH proxmox-backup v3 4/6] fix #3690: cli: " Markus Frank
2023-11-28 17:43 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-28 13:23 ` [pbs-devel] [PATCH proxmox-backup v3 5/6] fix #3690: ui: enable wipe disk in StorageAndDisks Markus Frank
2023-11-28 17:44 ` [pbs-devel] applied: " Thomas Lamprecht
2023-11-28 13:23 ` Markus Frank [this message]
2023-11-28 17:48 ` [pbs-devel] [PATCH proxmox-backup v3 6/6] tools: prohibit disk wipe of EFI partition Thomas Lamprecht
2023-11-28 21:56 ` Roland
2023-11-28 14:20 ` [pbs-devel] [PATCH proxmox-backup v3 0/6] fix #3690: wipe disk Lukas Wagner
2023-11-28 14:38 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128132323.162721-7-m.frank@proxmox.com \
--to=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.