From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH network 0/7] PUT API endpoint changes
Date: Wed, 22 Nov 2023 12:53:43 +0100 [thread overview]
Message-ID: <20231122115350.131255-1-w.bumiller@proxmox.com> (raw)
This is a breaking API change for zones, vnets and subnets!
These previously expected the *complete* config, which is not how our
usual SectionConfigs work.
Further, they advertised a 'delete' API parameter which was simply
passed through as a config property which of course failed validation.
Instead, they now merge the provided changes the way we normally do, and
handle the 'delete' parameter.
This affects:
- /cluster/sdn/zones/<id>
- /cluster/sdn/vnets/<id>
- /cluster/sdn/vnets/<id>/subnets/<subnet>
Additionally, these already took partial updates, but ignored the
'delete' parameter, which is fixed in this series:
- /cluster/sdn/ipams/<id>
- /cluster/sdn/dns/<id>
- /cluster/sdn/controllers/<id>
Wolfgang Bumiller (7):
Revert "sdn: require ipam in simple plugin for dhcp"
api: take partial configs for PUT /cluster/sdn/zones/<id>
api: take partial configs for PUT /cluster/sdn/vnets/<id>
api: take partial configs for PUT /cluster/sdn/vnets/<n>/subnets/<i>
api: handle delete parameter when updating ipams
api: handle delete parameter when updating dns entries
api: handle delete parameter when updating controllers
src/PVE/API2/Network/SDN/Controllers.pm | 7 +++++++
src/PVE/API2/Network/SDN/Dns.pm | 7 +++++++
src/PVE/API2/Network/SDN/Ipams.pm | 7 +++++++
src/PVE/API2/Network/SDN/Subnets.pm | 12 ++++++++++--
src/PVE/API2/Network/SDN/Vnets.pm | 24 +++++++++++++++++++----
src/PVE/API2/Network/SDN/Zones.pm | 18 ++++++++++++++---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 -
7 files changed, 66 insertions(+), 10 deletions(-)
--
2.39.2
next reply other threads:[~2023-11-22 11:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 11:53 Wolfgang Bumiller [this message]
2023-11-22 11:53 ` [pve-devel] [PATCH network 1/7] Revert "sdn: require ipam in simple plugin for dhcp" Wolfgang Bumiller
2023-11-22 11:53 ` [pve-devel] [PATCH network 2/7] api: take partial configs for PUT /cluster/sdn/zones/<id> Wolfgang Bumiller
2023-11-22 11:53 ` [pve-devel] [PATCH network 3/7] api: take partial configs for PUT /cluster/sdn/vnets/<id> Wolfgang Bumiller
2023-11-22 11:53 ` [pve-devel] [PATCH network 4/7] api: take partial configs for PUT /cluster/sdn/vnets/<n>/subnets/<i> Wolfgang Bumiller
2023-11-22 11:53 ` [pve-devel] [PATCH network 5/7] api: handle delete parameter when updating ipams Wolfgang Bumiller
2023-11-22 11:53 ` [pve-devel] [PATCH network 6/7] api: handle delete parameter when updating dns entries Wolfgang Bumiller
2023-11-22 11:53 ` [pve-devel] [PATCH network 7/7] api: handle delete parameter when updating controllers Wolfgang Bumiller
2023-11-22 12:26 ` [pve-devel] applied-series: [PATCH network 0/7] PUT API endpoint changes Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122115350.131255-1-w.bumiller@proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.