From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 guest-common/manager 0/5] vzdump: add 'notification-mode' parameter
Date: Tue, 21 Nov 2023 13:23:23 +0100 [thread overview]
Message-ID: <20231121122328.134930-1-l.wagner@proxmox.com> (raw)
This patch series adds the 'notification-mode' setting for backup jobs.
It allows users to choose between the 'old-style' notifications
(mail to configured address, directly via a call to sendmail) or
the 'new-style' notification system.
notification-mode has three possible values:
- legacy-sendmail: Use old system, considering mailto/mailtnotification parameters
- notification-system: Use the new system (always sending a notification, irregardless
of success/failure. The user is supposed to configure filtering/matching in
notification settings)
- auto: use old system if mailto is set, or new system if not
This should provide a fix/workaround for the users' reports of
- double notifications (these happened in case mailto was set to the same address
as root@pam)
- notifications always being sent, even if 'mailnotification' is set to failure
Changes v2 -> v3:
- change field text in the GUI for the 'mailnotification' param
This should highlight that this setting only affects the 'legacy-sendmail'
notification mails
pve-guest-common:
Lukas Wagner (1):
vzdump: config: add 'notification-mode' param for backup jobs
src/PVE/VZDump/Common.pm | 14 ++++++++++++++
1 file changed, 14 insertions(+)
pve-manager:
Lukas Wagner (4):
vzdump: support 'notification-mode' parameter
ui: backup jobs: add 'notification-mode' selector for backup jobs
ui: backup: add 'notification-mode' param for one-shot backup jobs.
ui: backup job: change field text for 'mailnotification' field
PVE/VZDump.pm | 95 +++++++++++--------
www/manager6/dc/Backup.js | 35 ++++++-
.../form/NotificationPolicySelector.js | 2 +-
www/manager6/window/Backup.js | 25 +++++
4 files changed, 117 insertions(+), 40 deletions(-)
Summary over all repositories:
5 files changed, 131 insertions(+), 40 deletions(-)
--
murpp v0.4.0
next reply other threads:[~2023-11-21 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:23 Lukas Wagner [this message]
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-guest-common 1/5] vzdump: config: add 'notification-mode' param for backup jobs Lukas Wagner
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 2/5] vzdump: support 'notification-mode' parameter Lukas Wagner
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 3/5] ui: backup jobs: add 'notification-mode' selector for backup jobs Lukas Wagner
2023-11-21 12:51 ` Philipp Hufnagl
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add 'notification-mode' param for one-shot " Lukas Wagner
[not found] ` <6e27a91f-2a4b-4072-87ee-f097dd175a9e@proxmox.com>
2023-11-21 12:42 ` Lukas Wagner
2023-11-21 12:23 ` [pve-devel] [PATCH v3 pve-manager 5/5] ui: backup job: change field text for 'mailnotification' field Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121122328.134930-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal