From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH access-control/manager 0/4] fix #1148: nested pools
Date: Mon, 20 Nov 2023 08:21:54 +0100 [thread overview]
Message-ID: <20231120072158.74101-1-f.gruenbichler@proxmox.com> (raw)
this series extends the poolname to allow (for now) two '/' inside the
name to nest pools like this:
parent/child/grandchild
since '/' is a bad character for path parameters, some API shuffling is
needed. other approaches that were tried but discarded, or rejected
outright:
- urlencoding
- systemd-escape
- manual encoding/escaping
- just encoding the parent/children in user.cfg, but not in the pool name
switching over some of the UI pool lists to also nest them visually should
be do-able as a follow-up.
changes since RFC:
- some style improvements, RE adaptation
pve-access-control:
Fabian Grünbichler (2):
allow up to three levels of pool nesting
pools: record parent/subpool information
src/PVE/AccessControl.pm | 26 +++++++++++++++++++++++---
src/test/parser_writer.pl | 4 ++++
src/test/perm-test6.pl | 16 ++++++++++++++++
src/test/test6.cfg | 5 +++++
4 files changed, 48 insertions(+), 3 deletions(-)
pve-manager:
Fabian Grünbichler (2):
api: pools: support nested pools
ui: pools: switch to new API endpoints
PVE/API2/Pool.pm | 243 +++++++++++++++++++++++--------
www/manager6/dc/PoolView.js | 3 +
www/manager6/grid/PoolMembers.js | 14 +-
www/manager6/pool/StatusView.js | 2 +-
4 files changed, 196 insertions(+), 66 deletions(-)
--
2.39.2
reply other threads:[~2023-11-20 7:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120072158.74101-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.