* [pve-devel] [PATCH manager 1/2] ui: ipview: Use monospace font for IPs and MAC addresses
@ 2023-11-16 13:13 Maximiliano Sandoval R
2023-11-16 13:13 ` [pve-devel] [PATCH manager 2/2] ui: ipview: Increase the width of the MAC column Maximiliano Sandoval R
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval R @ 2023-11-16 13:13 UTC (permalink / raw)
To: pve-devel
It becomes easier to read when you have multiple rows showing MACs when
they have the same size.
Signed-off-by: Maximiliano Sandoval R <m.sandoval@proxmox.com>
---
www/manager6/qemu/AgentIPView.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index 1411361a..1567bb42 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -22,13 +22,17 @@ Ext.define('PVE.window.IPInfo', {
dataIndex: 'hardware-address',
text: gettext('MAC address'),
width: 140,
+ renderer: function(val, metaData) {
+ metaData.style += 'font-family: monospace;';
+ return val;
+ },
},
{
dataIndex: 'ip-addresses',
text: gettext('IP address'),
align: 'right',
flex: 4,
- renderer: function(val) {
+ renderer: function(val, metaData) {
if (!Ext.isArray(val)) {
return '';
}
@@ -40,6 +44,7 @@ Ext.define('PVE.window.IPInfo', {
ips.push(addr + '/' + pref);
}
});
+ metaData.style += 'font-family: monospace;';
return ips.join('<br>');
},
},
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] [PATCH manager 2/2] ui: ipview: Increase the width of the MAC column
2023-11-16 13:13 [pve-devel] [PATCH manager 1/2] ui: ipview: Use monospace font for IPs and MAC addresses Maximiliano Sandoval R
@ 2023-11-16 13:13 ` Maximiliano Sandoval R
0 siblings, 0 replies; 2+ messages in thread
From: Maximiliano Sandoval R @ 2023-11-16 13:13 UTC (permalink / raw)
To: pve-devel
The latest change made the MACs monospaced, hence they do require more
space now. A multiple of 17 was chosen to match the number of
characters.
Signed-off-by: Maximiliano Sandoval R <m.sandoval@proxmox.com>
---
www/manager6/qemu/AgentIPView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index 1567bb42..67aeac66 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -21,7 +21,7 @@ Ext.define('PVE.window.IPInfo', {
{
dataIndex: 'hardware-address',
text: gettext('MAC address'),
- width: 140,
+ width: 170,
renderer: function(val, metaData) {
metaData.style += 'font-family: monospace;';
return val;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-16 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-16 13:13 [pve-devel] [PATCH manager 1/2] ui: ipview: Use monospace font for IPs and MAC addresses Maximiliano Sandoval R
2023-11-16 13:13 ` [pve-devel] [PATCH manager 2/2] ui: ipview: Increase the width of the MAC column Maximiliano Sandoval R
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal