* [pve-devel] [PATCH manager] acme: mark caaIdentities as an array
@ 2023-11-13 14:11 Folke Gleumes
2023-11-13 14:15 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Folke Gleumes @ 2023-11-13 14:11 UTC (permalink / raw)
To: pve-devel
caaIdentities was mistakenly labled as a string in a previous patch and
not as an array of strings, as it is defined in the rfc [0].
[0] https://datatracker.ietf.org/doc/html/rfc8555#section-7.1.1
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
---
This is a followup to Thomas correction, regarding the metadata sent by
the CA[1]
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-November/060029.html
PVE/API2/ACMEAccount.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm
index 93820ec4..3e3cbd32 100644
--- a/PVE/API2/ACMEAccount.pm
+++ b/PVE/API2/ACMEAccount.pm
@@ -402,7 +402,10 @@ __PACKAGE__->register_method ({
},
caaIdentities => {
description => 'Hostnames referring to the ACME servers.',
- type => 'string',
+ type => 'array',
+ items => {
+ type => 'string',
+ },
optional => 1,
},
},
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] acme: mark caaIdentities as an array
2023-11-13 14:11 [pve-devel] [PATCH manager] acme: mark caaIdentities as an array Folke Gleumes
@ 2023-11-13 14:15 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-13 14:15 UTC (permalink / raw)
To: Proxmox VE development discussion, Folke Gleumes
Am 13/11/2023 um 15:11 schrieb Folke Gleumes:
> caaIdentities was mistakenly labled as a string in a previous patch and
> not as an array of strings, as it is defined in the rfc [0].
>
> [0] https://datatracker.ietf.org/doc/html/rfc8555#section-7.1.1
>
> Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
> ---
>
> This is a followup to Thomas correction, regarding the metadata sent by
> the CA[1]
>
> [1] https://lists.proxmox.com/pipermail/pve-devel/2023-November/060029.html
>
> PVE/API2/ACMEAccount.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-13 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 14:11 [pve-devel] [PATCH manager] acme: mark caaIdentities as an array Folke Gleumes
2023-11-13 14:15 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.