From: Folke Gleumes <f.gleumes@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] acme: mark caaIdentities as an array
Date: Mon, 13 Nov 2023 15:11:25 +0100 [thread overview]
Message-ID: <20231113141125.228280-1-f.gleumes@proxmox.com> (raw)
caaIdentities was mistakenly labled as a string in a previous patch and
not as an array of strings, as it is defined in the rfc [0].
[0] https://datatracker.ietf.org/doc/html/rfc8555#section-7.1.1
Signed-off-by: Folke Gleumes <f.gleumes@proxmox.com>
---
This is a followup to Thomas correction, regarding the metadata sent by
the CA[1]
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-November/060029.html
PVE/API2/ACMEAccount.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm
index 93820ec4..3e3cbd32 100644
--- a/PVE/API2/ACMEAccount.pm
+++ b/PVE/API2/ACMEAccount.pm
@@ -402,7 +402,10 @@ __PACKAGE__->register_method ({
},
caaIdentities => {
description => 'Hostnames referring to the ACME servers.',
- type => 'string',
+ type => 'array',
+ items => {
+ type => 'string',
+ },
optional => 1,
},
},
--
2.39.2
next reply other threads:[~2023-11-13 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 14:11 Folke Gleumes [this message]
2023-11-13 14:15 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113141125.228280-1-f.gleumes@proxmox.com \
--to=f.gleumes@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.