From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2 0/8] refactor and improve installation progress
Date: Fri, 10 Nov 2023 15:17:18 +0100 [thread overview]
Message-ID: <20231110141727.597039-1-c.heiss@proxmox.com> (raw)
First #5 patches splits out the gigantic install progress dialog into its
own module; then applying some divide-and-conquer to make it more
readable and get the inner >150 lines closure down to a more
maintainable state. Purely code movement without any functional changes.
Patch #6 improves the error handling during the interaction with the
low-level installer, by providing the user with better error messages in
case something goes wrong.
Patch #7 does some code de-duplication for the low-lever installer.
Patch #8 improves the auto-reboot message/UX by counting down the
timeout, to match its GUI counterpart.
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058510.html
Notable changes v1 -> v2:
* rebased on latest master
* added patch #2, split out from #1
Christoph Heiss (8):
tui: move install progress dialog into own view module
tui: install_progress: move progress task into own function
tui: install_progress: split out low-level installer spawing into own
function
tui: install_progress: split out reboot handling into own function
tui: install_progress: split out prompt logic into own function
tui: install_progress: handle errors in ui message loop more
gracefully
low-level: avoid open-coding config reading, parsing and merging
low-level, tui: count down auto-reboot timeout
proxmox-installer-common/src/setup.rs | 22 +-
proxmox-low-level-installer | 70 +++--
proxmox-tui-installer/src/main.rs | 233 +---------------
.../src/views/install_progress.rs | 253 ++++++++++++++++++
proxmox-tui-installer/src/views/mod.rs | 3 +
5 files changed, 316 insertions(+), 265 deletions(-)
create mode 100644 proxmox-tui-installer/src/views/install_progress.rs
--
2.41.0
next reply other threads:[~2023-11-10 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 14:17 Christoph Heiss [this message]
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 1/8] tui: move install progress dialog into own view module Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 2/8] tui: install_progress: move progress task into own function Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 3/8] tui: install_progress: split out low-level installer spawing " Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 4/8] tui: install_progress: split out reboot handling " Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 5/8] tui: install_progress: split out prompt logic " Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 6/8] tui: install_progress: handle errors in ui message loop more gracefully Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 7/8] low-level: avoid open-coding config reading, parsing and merging Christoph Heiss
2023-11-10 14:17 ` [pve-devel] [PATCH installer v2 8/8] low-level, tui: count down auto-reboot timeout Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110141727.597039-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.