From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/3] ui: tags: fix focus for edit mode
Date: Thu, 19 Oct 2023 15:36:05 +0200 [thread overview]
Message-ID: <20231019133607.1416999-1-d.csapak@proxmox.com> (raw)
such that one can tab through the editable tag fields.
We have to handle that manually, since ExtJs does not expect
contenteditable html tags for focus handling.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/Tag.js | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js
index be72d7ba..6b1d6aa5 100644
--- a/www/manager6/form/Tag.js
+++ b/www/manager6/form/Tag.js
@@ -13,6 +13,15 @@ Ext.define('Proxmox.form.Tag', {
'<i class="action fa fa-minus-square"></i>',
],
+ focusable: true,
+ getFocusEl: function() {
+ return Ext.get(this.tagEl());
+ },
+
+ onFocus: function() {
+ this.selectText();
+ },
+
// contains tags not to show in the picker and not allowing to set
filter: [],
--
2.30.2
next reply other threads:[~2023-10-19 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 13:36 Dominik Csapak [this message]
2023-10-19 13:36 ` [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content Dominik Csapak
2023-10-19 13:59 ` Dominik Csapak
2023-10-24 9:53 ` Thomas Lamprecht
2023-10-24 9:57 ` Dominik Csapak
2023-10-24 10:07 ` Thomas Lamprecht
2023-10-24 10:51 ` Dominik Csapak
2023-10-24 10:52 ` Thomas Lamprecht
2023-10-19 13:36 ` [pve-devel] [PATCH manager 3/3] ui: wizards: allow adding tags in the qemu/lxc create wizard Dominik Csapak
2023-10-24 14:48 ` Thomas Lamprecht
2023-10-24 14:49 ` [pve-devel] applied: [PATCH manager 1/3] ui: tags: fix focus for edit mode Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019133607.1416999-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal