From: Max Carrara <m.carrara@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: McTwist <rajb89@hotmail.com>
Subject: [pbs-devel] [PATCH proxmox-backup] fix #4779: client: add missing "Connection" header for HTTP2 upgrade
Date: Thu, 19 Oct 2023 10:57:24 +0200 [thread overview]
Message-ID: <20231019085724.385356-1-m.carrara@proxmox.com> (raw)
This commit adds the missing "Connection: upgrade" HTTP header[1]
when requesting an upgrade to HTTP 2.
[1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Upgrade
Reported-By: McTwist <rajb89@hotmail.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
pbs-client/src/http_client.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs
index 90d0d04b..b803c19f 100644
--- a/pbs-client/src/http_client.rs
+++ b/pbs-client/src/http_client.rs
@@ -764,6 +764,8 @@ impl HttpClient {
);
}
+ req.headers_mut()
+ .insert("Connection", HeaderValue::from_str("upgrade").unwrap());
req.headers_mut()
.insert("UPGRADE", HeaderValue::from_str(&protocol_name).unwrap());
--
2.39.2
next reply other threads:[~2023-10-19 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 8:57 Max Carrara [this message]
2023-10-19 14:50 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019085724.385356-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=rajb89@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.