all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] Correct DNS IP check on management interface setup
Date: Mon, 16 Oct 2023 12:20:06 +0200	[thread overview]
Message-ID: <20231016102006.18064-1-f.schauer@proxmox.com> (raw)

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 proxinstall | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxinstall b/proxinstall
index d5b2565..764187f 100755
--- a/proxinstall
+++ b/proxinstall
@@ -481,8 +481,8 @@ sub create_ipconf_view {
 	$text = $ipconf_entry_dns->get_text();
 	my ($dns_ip, $dns_ip_version) = parse_ip_address($text);
 	if (!defined($dns_ip) || $dns_ip_version != $ipversion) {
-	    my $msg = defined($gateway_ip)
-	        ? "DNS and host IP version must not differ (IPv$gateway_ip_version != IPv$ipversion)."
+	    my $msg = defined($dns_ip)
+	        ? "DNS and host IP version must not differ (IPv$dns_ip_version != IPv$ipversion)."
 	        : "DNS IP is not valid.";
 	    Proxmox::UI::message($msg);
 	    $ipconf_entry_dns->grab_focus();
-- 
2.39.2





             reply	other threads:[~2023-10-16 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 10:20 Filip Schauer [this message]
2023-11-06 16:40 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016102006.18064-1-f.schauer@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal