From: Stefan Lendl <s.lendl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI
Date: Fri, 13 Oct 2023 13:03:47 +0200 [thread overview]
Message-ID: <20231013110347.80854-1-s.lendl@proxmox.com> (raw)
Make this consistent with PVE networking which has a Comment option.
Aliases used in VNet are basically comments if the id which is limited
to 8 chars is too long.
Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
---
www/manager6/sdn/VnetEdit.js | 2 +-
www/manager6/sdn/VnetView.js | 2 +-
www/manager6/sdn/ZoneContentView.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js
index 0f55595f..12642f85 100644
--- a/www/manager6/sdn/VnetEdit.js
+++ b/www/manager6/sdn/VnetEdit.js
@@ -31,7 +31,7 @@ Ext.define('PVE.sdn.VnetInputPanel', {
{
xtype: 'textfield',
name: 'alias',
- fieldLabel: gettext('Alias'),
+ fieldLabel: gettext('Comment'),
allowBlank: true,
},
{
diff --git a/www/manager6/sdn/VnetView.js b/www/manager6/sdn/VnetView.js
index 3fd3c916..5c153f6b 100644
--- a/www/manager6/sdn/VnetView.js
+++ b/www/manager6/sdn/VnetView.js
@@ -93,7 +93,7 @@ Ext.define('PVE.sdn.VnetView', {
},
},
{
- header: gettext('Alias'),
+ header: gettext('Comment'),
flex: 1,
dataIndex: 'alias',
renderer: function(value, metaData, rec) {
diff --git a/www/manager6/sdn/ZoneContentView.js b/www/manager6/sdn/ZoneContentView.js
index 2a3cbf52..107be97e 100644
--- a/www/manager6/sdn/ZoneContentView.js
+++ b/www/manager6/sdn/ZoneContentView.js
@@ -62,7 +62,7 @@ Ext.define('PVE.sdn.ZoneContentView', {
dataIndex: 'vnet',
},
{
- header: 'Alias',
+ header: 'Comment',
width: 300,
sortable: true,
dataIndex: 'alias',
--
2.41.0
next reply other threads:[~2023-10-13 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 11:03 Stefan Lendl [this message]
2023-10-13 11:21 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013110347.80854-1-s.lendl@proxmox.com \
--to=s.lendl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.