all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v3] ui: DirEdit: LVMEdit: add hint when to enable shared
Date: Tue, 10 Oct 2023 15:24:52 +0200	[thread overview]
Message-ID: <20231010132452.3340635-1-a.lauterer@proxmox.com> (raw)

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
changes since v2: fixed missing trailing comma

 www/manager6/storage/DirEdit.js | 4 ++++
 www/manager6/storage/LVMEdit.js | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 7e9ec44d..3e2025fc 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
 		name: 'shared',
 		uncheckedValue: 0,
 		fieldLabel: gettext('Shared'),
+		autoEl: {
+		    tag: 'div',
+		    'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
+		},
 	    },
 	];
 
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 75c7bdb8..75af6bf7 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
 	    name: 'shared',
 	    uncheckedValue: 0,
 	    fieldLabel: gettext('Shared'),
+	    autoEl: {
+		tag: 'div',
+		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
+	    },
 	},
     ],
 });
-- 
2.39.2





             reply	other threads:[~2023-10-10 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 13:24 Aaron Lauterer [this message]
2024-01-09  9:35 ` [pve-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010132452.3340635-1-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal