all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages
@ 2023-09-12 12:29 Fiona Ebner
  2024-04-11 11:57 ` Fiona Ebner
  2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: Fiona Ebner @ 2023-09-12 12:29 UTC (permalink / raw)
  To: pve-devel

The one with the backup flag was reported in the community forum:
https://forum.proxmox.com/threads/77254/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Changes in v2:
    * Further improve message as suggested by Sterzy.

 pve-zsync | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pve-zsync b/pve-zsync
index 98190b2..de5d46f 100755
--- a/pve-zsync
+++ b/pve-zsync
@@ -949,11 +949,12 @@ sub parse_disks {
 	    $num++;
 
 	} else {
-	    die "ERROR: in path\n";
+	    die "unexpected path '$path'\n";
 	}
     }
 
-    die "Vm include no disk on zfs.\n" if !$disks->{0};
+    die "Guest does not include any ZFS volumes (or all are excluded by the backup flag).\n"
+	if !$disks->{0};
     return $disks;
 }
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-12  7:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 12:29 [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages Fiona Ebner
2024-04-11 11:57 ` Fiona Ebner
2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-12  7:07   ` Fiona Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal