all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2] close #3777: Add source information to backup logs
Date: Fri,  8 Sep 2023 16:01:14 +0200	[thread overview]
Message-ID: <20230908140114.266139-1-g.goller@proxmox.com> (raw)

This will show the ip-address of the client creating
the backup in the logs. For example it will output:
"starting new backup on datastore 'test1' from ::ffff:192.168.1.192:
"host/test/2023-08-21T07:28:10Z"".

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---

update v1:
 - improved unwrapping of ip adress

 src/api2/backup/mod.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs
index 652d5baa..18fad745 100644
--- a/src/api2/backup/mod.rs
+++ b/src/api2/backup/mod.rs
@@ -214,9 +214,12 @@ fn upgrade_to_backup_protocol(
                 env.debug = debug;
                 env.last_backup = last_backup;
 
+                let origin = match rpcenv.get_client_ip().map(|addr| addr.ip()) {
+                    Some(ip) => format!(" from {ip}"),
+                    None => "".into(),
+                };
                 env.log(format!(
-                    "starting new {} on datastore '{}': {:?}",
-                    worker_type, store, path
+                    "starting new {worker_type} on datastore '{store}'{origin}: {path:?}",
                 ));
 
                 let service =
-- 
2.39.2





             reply	other threads:[~2023-09-08 14:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 14:01 Gabriel Goller [this message]
2023-09-18 14:39 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230908140114.266139-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal