* [pbs-devel] [PATCH proxmox-backup] ui: don't show reset button on zfs creation
@ 2023-09-07 12:19 Dominik Csapak
2023-09-07 15:46 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2023-09-07 12:19 UTC (permalink / raw)
To: pbs-devel
the reset button only makes sense for editing existing entries,
not for creating new.
This brings it inline with the ZFS create window from PVE.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this is just a short term improvement. ideally we can reuse the same
window for pve and pbs in the future.
www/window/ZFSCreate.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/window/ZFSCreate.js b/www/window/ZFSCreate.js
index 28b90d82..71f88d9f 100644
--- a/www/window/ZFSCreate.js
+++ b/www/window/ZFSCreate.js
@@ -5,6 +5,7 @@ Ext.define('PBS.window.CreateZFS', {
subject: 'ZFS',
showProgress: true,
+ isCreate: true,
onlineHelp: 'chapter_zfs',
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: Re: [PATCH proxmox-backup] ui: don't show reset button on zfs creation
2023-09-07 12:19 [pbs-devel] [PATCH proxmox-backup] ui: don't show reset button on zfs creation Dominik Csapak
@ 2023-09-07 15:46 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-09-07 15:46 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
On 07/09/2023 14:19, Dominik Csapak wrote:
> the reset button only makes sense for editing existing entries,
> not for creating new.
>
> This brings it inline with the ZFS create window from PVE.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this is just a short term improvement. ideally we can reuse the same
> window for pve and pbs in the future.
>
> www/window/ZFSCreate.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-07 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-07 12:19 [pbs-devel] [PATCH proxmox-backup] ui: don't show reset button on zfs creation Dominik Csapak
2023-09-07 15:46 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal