* [pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons
@ 2023-09-06 13:09 Maximiliano Sandoval
2023-09-07 6:33 ` [pmg-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2023-09-06 13:09 UTC (permalink / raw)
To: pmg-devel
From a UX perspective flat buttons, i.e. buttons without a frame or
background, are not obviously clickable without an icon.
The choice of icons was taken from pve-manager's Utils.js module.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
- Use folder icon as suggest in v2 of the patch
- Improved commit message
js/BackupConfiguration.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/BackupConfiguration.js b/js/BackupConfiguration.js
index e21771f..ed9959c 100644
--- a/js/BackupConfiguration.js
+++ b/js/BackupConfiguration.js
@@ -12,11 +12,13 @@ Ext.define('PMG.BackupConfiguration', {
itemId: 'local',
title: gettext('Local Backup/Restore'),
xtype: 'pmgBackupRestore',
+ iconCls: 'fa fa-folder',
},
{
itemId: 'proxmoxbackupserver',
title: 'Proxmox Backup Server',
xtype: 'pmgPBSConfig',
+ iconCls: 'fa fa-floppy-o',
},
],
});
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons
2023-09-06 13:09 [pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons Maximiliano Sandoval
@ 2023-09-07 6:33 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-09-07 6:33 UTC (permalink / raw)
To: Maximiliano Sandoval, pmg-devel
Am 06/09/2023 um 15:09 schrieb Maximiliano Sandoval:
> From a UX perspective flat buttons, i.e. buttons without a frame or
> background, are not obviously clickable without an icon.
>
> The choice of icons was taken from pve-manager's Utils.js module.
I amended the commit to mention the storageSchema map and change
Utils.js to PVE.Utils, as that's the module name relevant when
actually using it.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v2:
> - Use folder icon as suggest in v2 of the patch
> - Improved commit message
>
> js/BackupConfiguration.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-07 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 13:09 [pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons Maximiliano Sandoval
2023-09-07 6:33 ` [pmg-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal