* [pve-devel] [PATCH manager v1] fix #4947 spice: correct filename extension safari
@ 2023-09-06 9:37 Markus Frank
2023-09-06 14:47 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Markus Frank @ 2023-09-06 9:37 UTC (permalink / raw)
To: pve-devel
Fix file extension for SPICE config download on
AppleWebKit browsers to ensure proper application
association on MacOS.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
www/manager6/Utils.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 6d4842df..06b63315 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1401,10 +1401,11 @@ Ext.define('PVE.Utils', {
css: 'display:none;visibility:hidden;height:0px;',
});
- // Note: we need to tell Android and Chrome the correct file name extension
+ // Note: we need to tell Android, AppleWebKit and Chrome
+ // the correct file name extension
// but we do not set 'download' tag for other environments, because
// It can have strange side effects (additional user prompt on firefox)
- if (navigator.userAgent.match(/Android|Chrome/i)) {
+ if (navigator.userAgent.match(/Android|AppleWebKit|Chrome/i)) {
link.download = name;
}
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager v1] fix #4947 spice: correct filename extension safari
2023-09-06 9:37 [pve-devel] [PATCH manager v1] fix #4947 spice: correct filename extension safari Markus Frank
@ 2023-09-06 14:47 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-09-06 14:47 UTC (permalink / raw)
To: Proxmox VE development discussion, Markus Frank
Am 06/09/2023 um 11:37 schrieb Markus Frank:
> Fix file extension for SPICE config download on
> AppleWebKit browsers to ensure proper application
> association on MacOS.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> www/manager6/Utils.js | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
Would be also interesting to test if the comment still applies w.r.t.
"additional user prompt on firefox", as IIRC Firefox rework the download
handling a bit in some relatively recent version.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-06 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 9:37 [pve-devel] [PATCH manager v1] fix #4947 spice: correct filename extension safari Markus Frank
2023-09-06 14:47 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal