all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #4531: Fix ACME plugin edit form not detecting changes
Date: Tue, 29 Aug 2023 13:16:25 +0200	[thread overview]
Message-ID: <20230829111625.44426-1-f.schauer@proxmox.com> (raw)

Fix the ACME plugin edit form not detecting dirtychanges to the values
of textfields properly.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 src/window/ACMEPluginEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/window/ACMEPluginEdit.js b/src/window/ACMEPluginEdit.js
index 0f21527..f6d1bcd 100644
--- a/src/window/ACMEPluginEdit.js
+++ b/src/window/ACMEPluginEdit.js
@@ -126,7 +126,7 @@ Ext.define('Proxmox.window.ACMEPluginEdit', {
 		for (const [key, value] of Object.entries(data)) {
 		    if (me.createdFields[key]) {
 			me.createdFields[key].setValue(value);
-			me.createdFields[key].originalValue = me.originalValues[key];
+			me.createdFields[key].resetOriginalValue();
 		    } else {
 			extradata.push(`${key}=${value}`);
 		    }
-- 
2.39.2





             reply	other threads:[~2023-08-29 11:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 11:16 Filip Schauer [this message]
2023-08-30  9:07 ` Thomas Lamprecht
2023-08-30 10:45   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829111625.44426-1-f.schauer@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal