* [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared
@ 2023-08-21 10:06 Aaron Lauterer
2023-10-10 13:06 ` Fiona Ebner
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Lauterer @ 2023-08-21 10:06 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
www/manager6/storage/DirEdit.js | 4 ++++
www/manager6/storage/LVMEdit.js | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 7e9ec44d..8469a7c3 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
name: 'shared',
uncheckedValue: 0,
fieldLabel: gettext('Shared'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
+ }
},
];
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 75c7bdb8..0d9efd21 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
name: 'shared',
uncheckedValue: 0,
fieldLabel: gettext('Shared'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
+ }
},
],
});
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared
2023-08-21 10:06 [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared Aaron Lauterer
@ 2023-10-10 13:06 ` Fiona Ebner
2023-10-10 13:19 ` Aaron Lauterer
0 siblings, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2023-10-10 13:06 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer
Am 21.08.23 um 12:06 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/manager6/storage/DirEdit.js | 4 ++++
> www/manager6/storage/LVMEdit.js | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> index 7e9ec44d..8469a7c3 100644
> --- a/www/manager6/storage/DirEdit.js
> +++ b/www/manager6/storage/DirEdit.js
> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
> name: 'shared',
> uncheckedValue: 0,
> fieldLabel: gettext('Shared'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
> + }
eslint complains about missing trailing comma
> },
> ];
>
> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
> index 75c7bdb8..0d9efd21 100644
> --- a/www/manager6/storage/LVMEdit.js
> +++ b/www/manager6/storage/LVMEdit.js
> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
> name: 'shared',
> uncheckedValue: 0,
> fieldLabel: gettext('Shared'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
> + }
eslint complains about missing trailing comma
> },
> ],
> });
With those fixed:
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared
2023-10-10 13:06 ` Fiona Ebner
@ 2023-10-10 13:19 ` Aaron Lauterer
2023-10-10 14:31 ` Thomas Lamprecht
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Lauterer @ 2023-10-10 13:19 UTC (permalink / raw)
To: Fiona Ebner, Proxmox VE development discussion
On 10/10/23 15:06, Fiona Ebner wrote:
> Am 21.08.23 um 12:06 schrieb Aaron Lauterer:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> www/manager6/storage/DirEdit.js | 4 ++++
>> www/manager6/storage/LVMEdit.js | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>> index 7e9ec44d..8469a7c3 100644
>> --- a/www/manager6/storage/DirEdit.js
>> +++ b/www/manager6/storage/DirEdit.js
>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>> name: 'shared',
>> uncheckedValue: 0,
>> fieldLabel: gettext('Shared'),
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>> + }
>
> eslint complains about missing trailing comma
hmm, when did that happen... now it does it too for me. Will send another version with it fixed.
>
>> },
>> ];
>>
>> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
>> index 75c7bdb8..0d9efd21 100644
>> --- a/www/manager6/storage/LVMEdit.js
>> +++ b/www/manager6/storage/LVMEdit.js
>> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
>> name: 'shared',
>> uncheckedValue: 0,
>> fieldLabel: gettext('Shared'),
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
>> + }
>
> eslint complains about missing trailing comma
>
>> },
>> ],
>> });
>
> With those fixed:
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared
2023-10-10 13:19 ` Aaron Lauterer
@ 2023-10-10 14:31 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2023-10-10 14:31 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer, Fiona Ebner
Am 10/10/2023 um 15:19 schrieb Aaron Lauterer:
>>>
>>>
>>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>>> index 7e9ec44d..8469a7c3 100644
>>> --- a/www/manager6/storage/DirEdit.js
>>> +++ b/www/manager6/storage/DirEdit.js
>>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>>> name: 'shared',
>>> uncheckedValue: 0,
>>> fieldLabel: gettext('Shared'),
>>> + autoEl: {
>>> + tag: 'div',
>>> + 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>>> + }
>>
>> eslint complains about missing trailing comma
>
> hmm, when did that happen... now it does it too for me. Will send another version with it fixed.
We always had that rule enabled, it's a warning one, so `make install` will
only output the warning but continue, to make modify-build-test cycles easier,
but when building a debian package all the eslint warnings become errors.
There's a slight possibility that an earlier eslint had a false-negative here,
but tbh., I'd find that a bit odd as it's a relatively simple check.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-10 14:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21 10:06 [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared Aaron Lauterer
2023-10-10 13:06 ` Fiona Ebner
2023-10-10 13:19 ` Aaron Lauterer
2023-10-10 14:31 ` Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal