From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH V2 common 1/1] fix #4849: download file from url: add opt parameter for a decompression command
Date: Thu, 27 Jul 2023 17:28:15 +0200 [thread overview]
Message-ID: <20230727152817.775699-2-p.hufnagl@proxmox.com> (raw)
In-Reply-To: <20230727152817.775699-1-p.hufnagl@proxmox.com>
Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
---
src/PVE/Tools.pm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 9ffac12..d9869e8 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -2059,6 +2059,15 @@ sub download_file_from_url {
}
print "download of '$url' to '$dest' finished\n";
+
+ if ($opts->{decompression_command}) {
+ my $cmd = join(' ', $opts->{decompression_command}->@*, $dest);
+ eval{run_command($cmd);};
+ my $rerr = $@;
+ unlink $dest;
+ die "$rerr\n" if $rerr;
+ print "decompressed $dest\n";
+ }
}
sub get_file_hash {
--
2.39.2
next prev parent reply other threads:[~2023-07-27 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:28 [pve-devel] [PATCH V2 storage/manager/common 0/3] allow download of compressed ISOs Philipp Hufnagl
2023-07-27 15:28 ` Philipp Hufnagl [this message]
2023-07-28 8:11 ` [pve-devel] [PATCH V2 common 1/1] fix #4849: download file from url: add opt parameter for a decompression command Fabian Grünbichler
2023-07-27 15:28 ` [pve-devel] [PATCH V2 manager 1/1] fix #4849: download to storage: automatically dectect and configure compression Philipp Hufnagl
2023-07-27 15:28 ` [pve-devel] [PATCH V2 storage 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs Philipp Hufnagl
2023-07-28 8:11 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727152817.775699-2-p.hufnagl@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.