all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer 0/7] refactor; improve installation progress
@ 2023-07-26 14:03 Christoph Heiss
  2023-07-26 14:03 ` [pve-devel] [PATCH installer 1/7] tui: move install progress dialog into own view module Christoph Heiss
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Christoph Heiss @ 2023-07-26 14:03 UTC (permalink / raw)
  To: pve-devel

First 5 patches splits out the gigantic install progress dialog into its
own module; then applying some divide-and-conquer to make it more
readable and get the inner >150 lines closure down to a more
maintainable state.

Patch 6 does some code de-duplication for the low-lever installer.

Patch 7 improves the auto-reboot message/UX by counting down the
timeout, to match its GUI counterpart.

Christoph Heiss (7):
  tui: move install progress dialog into own view module
  tui: install progress: split out low-level installer spawing into own
    function
  tui: install progress: split out reboot handling into own function
  tui: install progress: split out prompt logic into own function
  tui: install progress: handle errors in ui message loop more
    gracefully
  low-level: avoid open-coding config reading, parsing and merging
  low-level, tui: count down auto-reboot timeout

 proxmox-low-level-installer                   |  70 +++--
 proxmox-tui-installer/src/main.rs             | 235 +--------------
 .../src/views/install_progress.rs             | 275 ++++++++++++++++++
 proxmox-tui-installer/src/views/mod.rs        |   3 +
 4 files changed, 318 insertions(+), 265 deletions(-)
 create mode 100644 proxmox-tui-installer/src/views/install_progress.rs

--
2.41.0





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-07-26 14:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 14:03 [pve-devel] [PATCH installer 0/7] refactor; improve installation progress Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 1/7] tui: move install progress dialog into own view module Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 2/7] tui: install progress: split out low-level installer spawing into own function Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 3/7] tui: install progress: split out reboot handling " Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 4/7] tui: install progress: split out prompt logic " Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 5/7] tui: install progress: handle errors in ui message loop more gracefully Christoph Heiss
2023-07-26 14:04 ` [pve-devel] [PATCH installer 6/7] low-level: avoid open-coding config reading, parsing and merging Christoph Heiss
2023-07-26 14:04 ` [pve-devel] [PATCH installer 7/7] low-level, tui: count down auto-reboot timeout Christoph Heiss

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal