all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/3] ui: don't set the default value of combogrids to []
Date: Wed, 19 Jul 2023 14:11:12 +0200	[thread overview]
Message-ID: <20230719121112.229074-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230719121112.229074-1-d.csapak@proxmox.com>

the combogrid sets the default itself correctly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
depends on the widget-toolkit patch

 www/manager6/form/NodeSelector.js | 5 +----
 www/manager6/ha/GroupSelector.js  | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/www/manager6/form/NodeSelector.js b/www/manager6/form/NodeSelector.js
index c3e3da31..bc282287 100644
--- a/www/manager6/form/NodeSelector.js
+++ b/www/manager6/form/NodeSelector.js
@@ -12,10 +12,7 @@ Ext.define('PVE.form.NodeSelector', {
 
     // only allow those nodes (array)
     allowedNodes: undefined,
-    // set default value to empty array, else it inits it with
-    // null and after the store load it is an empty array,
-    // triggering dirtychange
-    value: [],
+
     valueField: 'node',
     displayField: 'node',
     store: {
diff --git a/www/manager6/ha/GroupSelector.js b/www/manager6/ha/GroupSelector.js
index 61ab0c03..1823472f 100644
--- a/www/manager6/ha/GroupSelector.js
+++ b/www/manager6/ha/GroupSelector.js
@@ -2,7 +2,6 @@ Ext.define('PVE.ha.GroupSelector', {
     extend: 'Proxmox.form.ComboGrid',
     alias: ['widget.pveHAGroupSelector'],
 
-    value: [],
     autoSelect: false,
     valueField: 'group',
     displayField: 'group',
-- 
2.30.2





  parent reply	other threads:[~2023-07-19 12:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 12:11 [pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling Dominik Csapak
2023-07-19 12:11 ` [pve-devel] [PATCH widget-toolkit 1/1] combogrid: initialze value with [] by default Dominik Csapak
2023-11-14  8:04   ` [pve-devel] applied: " Thomas Lamprecht
2023-07-19 12:11 ` [pve-devel] [PATCH manager 1/3] ui: ipset: make ip/cidr required Dominik Csapak
2023-07-19 12:11 ` [pve-devel] [PATCH manager 2/3] ui: don't set the default value of combogrids to '' Dominik Csapak
2023-07-19 12:11 ` Dominik Csapak [this message]
2023-07-19 12:22 ` [pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling Fabian Grünbichler
2023-11-14 15:52 ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230719121112.229074-5-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal