From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: replication: backup: use renderEnabledIcon to render the enabled column
Date: Tue, 18 Jul 2023 11:53:05 +0200 [thread overview]
Message-ID: <20230718095305.227893-1-l.wagner@proxmox.com> (raw)
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/Backup.js | 3 +--
www/manager6/grid/Replication.js | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 03a02651..e662dd36 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -722,8 +722,7 @@ Ext.define('PVE.dc.BackupView', {
width: 80,
dataIndex: 'enabled',
align: 'center',
- // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
- renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
+ renderer: Proxmox.Utils.renderEnabledIcon,
sortable: true,
},
{
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index 30cd6718..1e4e00fc 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -283,8 +283,7 @@ Ext.define('PVE.grid.ReplicaView', {
width: 80,
dataIndex: 'enabled',
align: 'center',
- // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
- renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
+ renderer: Proxmox.Utils.renderEnabledIcon,
sortable: true,
},
{
--
2.39.2
next reply other threads:[~2023-07-18 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 9:53 Lukas Wagner [this message]
2023-09-01 6:55 ` Lukas Wagner
2023-09-01 7:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718095305.227893-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.