From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully
Date: Fri, 7 Jul 2023 10:02:29 +0200 [thread overview]
Message-ID: <20230707080230.11949-1-f.ebner@proxmox.com> (raw)
which is passed by the backup job window when using selection mode
'all', would be converted to [""] and wrongly add an entry with VMID
0 because the item "" could not be found in the store.
Reported in the community forum:
https://forum.proxmox.com/threads/130164/
Fixes: 7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup edit")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Applying either of the patches to stable-7 is enough to fix the issue.
No changes in v2.
www/manager6/form/VMSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 4c0bba13..bf2c8df7 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -162,7 +162,7 @@ Ext.define('PVE.form.VMSelector', {
setValue: function(value) {
let me = this;
if (!Ext.isArray(value)) {
- value = value.split(',');
+ value = value === '' ? [] : value.split(',');
}
let store = me.getStore();
--
2.39.2
next reply other threads:[~2023-07-07 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 8:02 Fiona Ebner [this message]
2023-07-07 8:02 ` [pve-devel] [PATCH v2 manager 2/2] ui: vm selector: don't add invalid not found items Fiona Ebner
2023-09-25 11:18 ` Dominik Csapak
2023-08-30 9:15 ` [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully Fiona Ebner
2023-09-25 10:59 ` Fiona Ebner
2023-09-25 11:17 ` Dominik Csapak
2023-09-25 11:36 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707080230.11949-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal