all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH network/container/qemu-server v2 0/3] drop unused `firewall` argument to {add, del}_bridge_fdb()
Date: Wed,  5 Jul 2023 16:38:14 +0200	[thread overview]
Message-ID: <20230705143818.1359775-1-c.heiss@proxmox.com> (raw)

While working on this code, I noticed that the `firewall` argument is
never used (nor even declared) [0] in both
PVE::Network::{add,del}_bridge_fdb().

Thus drop it everywhere and avoid needlessly passing around things which
are never used anyway.

Did some quick smoke-testing and everything kept working fine, but as
there are really no functional changes, this should not effect anything.

[ Basically just a re-spin of [1], just refreshed all patches such that
they apply cleanly again. No actual changes between v1 and v2. ]

[0] https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/Network.pm;h=a4f5ba96;hb=HEAD#l299
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055970.html

pve-network:

Christoph Heiss (1):
  sdn: zones: drop unused `firewall` argument to {add, del}_bridge_fdb()

 src/PVE/Network/SDN/Zones.pm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

pve-container:

Christoph Heiss (1):
  net: drop unused `firewall` argument to add_bridge_fdb()

 src/PVE/LXC.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

qemu-server:

Christoph Heiss (1):
  net: drop unused `firewall` argument to {add, del}_bridge_fdb()

 PVE/QemuServer.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--
2.39.2





             reply	other threads:[~2023-07-05 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 14:38 Christoph Heiss [this message]
2023-07-05 14:38 ` [pve-devel] [PATCH network v2 1/1] sdn: zones: " Christoph Heiss
2023-07-05 14:38 ` [pve-devel] [PATCH container v2 2/2] net: drop unused `firewall` argument to add_bridge_fdb() Christoph Heiss
2023-07-05 14:38 ` [pve-devel] [PATCH qemu-server v2 3/3] net: drop unused `firewall` argument to {add, del}_bridge_fdb() Christoph Heiss
2024-07-22 16:16 ` [pve-devel] [PATCH network/container/qemu-server v2 0/3] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230705143818.1359775-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal