From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-login-manager 1/2] saved login: don't give outdated ticket to login form
Date: Tue, 4 Jul 2023 15:53:17 +0200 [thread overview]
Message-ID: <20230704135318.3278928-1-d.csapak@proxmox.com> (raw)
if the user was logged in in the past, but that ticket expired, we still
gave the expired ticket to the login form which tried to login with
that, producing a login error the first time the user pressed login.
we already get the correct ticket in a variable, so use that.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
lib/proxmox_login_selector.dart | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart
index e599461..8573ab0 100644
--- a/lib/proxmox_login_selector.dart
+++ b/lib/proxmox_login_selector.dart
@@ -207,7 +207,7 @@ class _ProxmoxLoginSelectorState extends State<ProxmoxLoginSelector> {
builder: (context) => ProxmoxLoginPage(
userModel: user,
isCreate: isCreate,
- ticket: user?.ticket,
+ ticket: ticket,
password: password,
)));
refreshFromStorage();
--
2.30.2
next reply other threads:[~2023-07-04 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 13:53 Dominik Csapak [this message]
2023-07-04 13:53 ` [pve-devel] [PATCH proxmox-login-manager 2/2] tfa: allow closing tfa form Dominik Csapak
2023-07-04 15:22 ` [pve-devel] applied-series: [PATCH proxmox-login-manager 1/2] saved login: don't give outdated ticket to login form Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704135318.3278928-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.