* [pmg-devel] [PATCH pmg-gui] fix tracking center with newer proxmox-widget-toolkit
@ 2023-06-26 14:52 Dominik Csapak
2023-06-27 11:39 ` [pmg-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2023-06-26 14:52 UTC (permalink / raw)
To: pmg-devel
newer widget-toolkit versions did change the DateTimeField a bit, and
now breaks when there is no viewModel anywhere, so add one as a stopgap
fix for now in the tracking center.
the real fix would have to be in DateTimeField itself, probably checking
if there is a bind.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
I just did not have time today to look into the code in
widget-toolkit. if someone finds an easy solution there go ahead, but
this should be fine as a stopgap...
js/MailTracker.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/MailTracker.js b/js/MailTracker.js
index 52641a4..1a170d8 100644
--- a/js/MailTracker.js
+++ b/js/MailTracker.js
@@ -38,6 +38,8 @@ Ext.define('PMG.MailTrackerFilter', {
},
},
+ viewModel: {},
+
getFilterParams: function() {
let me = this;
let param = {};
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-gui] fix tracking center with newer proxmox-widget-toolkit
2023-06-26 14:52 [pmg-devel] [PATCH pmg-gui] fix tracking center with newer proxmox-widget-toolkit Dominik Csapak
@ 2023-06-27 11:39 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-27 11:39 UTC (permalink / raw)
To: Dominik Csapak, pmg-devel
Am 26/06/2023 um 16:52 schrieb Dominik Csapak:
> newer widget-toolkit versions did change the DateTimeField a bit, and
> now breaks when there is no viewModel anywhere, so add one as a stopgap
> fix for now in the tracking center.
>
> the real fix would have to be in DateTimeField itself, probably checking
> if there is a bind.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> I just did not have time today to look into the code in
> widget-toolkit. if someone finds an easy solution there go ahead, but
> this should be fine as a stopgap...
>
> js/MailTracker.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-27 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 14:52 [pmg-devel] [PATCH pmg-gui] fix tracking center with newer proxmox-widget-toolkit Dominik Csapak
2023-06-27 11:39 ` [pmg-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal