From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIE ifupdown2/common] disable rx-vlan-filter on iface in vlan-aware-bridge
Date: Fri, 23 Jun 2023 11:02:55 +0200 [thread overview]
Message-ID: <20230623090258.284882-1-aderumier@odiso.com> (raw)
Hi,
Some nics like mellanox connect-x or intel i40e don't work with vlan-aware-bridge
when too many vlans are defined.
Depend of the model, connectx-3 is limited to 64 vlans, connect-x4 to 128vlans
https://forum.proxmox.com/threads/proxmox-7-and-mellanox-connectx4-and-vlan-aware-bridge.104926/#post-555269
i40e seem to throw errors like
Jan 18 14:44:27 jupiter kernel: [ 145.060365] i40e 0000:3d:00.0: Error I40E_AQ_RC_ENOSPC, forcing overflow promiscuous on PF
https://forum.proxmox.com/threads/error-i40e_aq_rc_enospc-forcing-overflow-promiscuous-on-pf.62875/
https://forum.proxmox.com/threads/proxmox-8-and-i40e-driver-kernel-6-2.129364/
rx-vlan-filter is only a protection to drop packets with unknown vlan at nic level.
(not related to vlan offloading, where nic can support any number of vlan)
When vlan-aware is enabled, bridge is already doing the vlan filtering, so it's pretty safe to disable it.
(AFAIK, it was not enabled on proxmox 5, as I didn't have mellanox problem at this time)
This patch serie add support to ifupdown2 to "rx-vlan-filter" and add ethtool as depend
and rx-vlan-filter is added to /etc/network/interfaces on phys nic if the nic is port of vlan aware bridge.
(or slave of bond port of vlan-aware-bridge)
fix:
https://bugzilla.proxmox.com/show_bug.cgi?id=2329
https://bugzilla.proxmox.com/show_bug.cgi?id=3893
(maybe they are other related bug reports)
ifupdown2:
Alexandre Derumier (2):
add ethtool as depend
patch: ethtool: add rx-vlan-filter support
debian/control | 4 +-
debian/patches/series | 1 +
...01-addons-ethtool-add-rx-vlan-filter.patch | 43 +++++++++++++++++++
ifupdown2 | 2 +-
4 files changed, 47 insertions(+), 3 deletions(-)
create mode 100644 debian/patches/upstream/0001-addons-ethtool-add-rx-vlan-filter.patch
pve-common:
Alexandre Derumier (1):
network_interfaces: disable rx-vlan-filter for physical interfaces
ports of a vlan-aware bridge
src/PVE/INotify.pm | 2 ++
1 file changed, 2 insertions(+)
--
2.39.2
next reply other threads:[~2023-06-23 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 9:02 Alexandre Derumier [this message]
2023-06-23 9:02 ` [pve-devel] [PATCH ifupdown2 1/2] add ethtool as depend Alexandre Derumier
2023-06-26 18:43 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-23 9:02 ` [pve-devel] [PATCH pve-common 1/1] network_interfaces: disable rx-vlan-filter for physical interfaces ports of a vlan-aware bridge Alexandre Derumier
2023-06-26 18:46 ` Thomas Lamprecht
2023-06-23 9:02 ` [pve-devel] [PATCH ifupdown2 2/2] patch: ethtool: add rx-vlan-filter support Alexandre Derumier
2023-06-26 18:42 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623090258.284882-1-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.