all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] tui: do not auto reboot on failures
@ 2023-06-22 13:08 Maximiliano Sandoval
  2023-06-22 13:31 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2023-06-22 13:08 UTC (permalink / raw)
  To: pve-devel

Otherwise the user only has 5 seconds to see the error message before
the machine reboots.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-tui-installer/src/main.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs
index d2a5fcf..8d05292 100644
--- a/proxmox-tui-installer/src/main.rs
+++ b/proxmox-tui-installer/src/main.rs
@@ -820,7 +820,7 @@ fn install_progress_dialog(siv: &mut Cursive) -> InstallerView {
                                     .map(|state| state.options.autoreboot)
                                     .unwrap_or_default();
 
-                                if autoreboot {
+                                if autoreboot && success {
                                     let cb_sink = siv.cb_sink();
                                     thread::spawn({
                                         let cb_sink = cb_sink.clone();
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH installer] tui: do not auto reboot on failures
  2023-06-22 13:08 [pve-devel] [PATCH installer] tui: do not auto reboot on failures Maximiliano Sandoval
@ 2023-06-22 13:31 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-22 13:31 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 22/06/2023 um 15:08 schrieb Maximiliano Sandoval:
> Otherwise the user only has 5 seconds to see the error message before
> the machine reboots.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  proxmox-tui-installer/src/main.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-22 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-22 13:08 [pve-devel] [PATCH installer] tui: do not auto reboot on failures Maximiliano Sandoval
2023-06-22 13:31 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal