From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH stable-7 manager] pve7to8: enable noout before upgrade
Date: Wed, 21 Jun 2023 18:19:47 +0200 [thread overview]
Message-ID: <20230621161948.116285-1-f.ebner@proxmox.com> (raw)
Just like 3b776617 ("pve6to7: enable noout before upgrade") last time,
it should be enabled in the stable branch to ensure users see the
warning before upgrade.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Intended only for the stable-7 branch.
PVE/CLI/pve7to8.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 73ea85b0..56af2732 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -543,7 +543,7 @@ sub check_ceph {
log_warn("unable to determine overall Ceph daemon versions!");
} elsif (keys %$overall_versions == 1) {
log_pass("single running overall version detected for all Ceph daemon types.");
- $noout_wanted = 0; # off post-upgrade, on pre-upgrade
+ $noout_wanted = 1; # off post-upgrade, on pre-upgrade
} elsif (keys $ceph_versions_simple->{overall}->%* != 1) {
log_warn("overall version mismatch detected, check 'ceph versions' output for details!");
}
--
2.39.2
next reply other threads:[~2023-06-21 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 16:19 Fiona Ebner [this message]
2023-06-21 16:19 ` [pve-devel] [PATCH manager] pve7to8: add reminder comment for noout_wanted variable Fiona Ebner
2023-06-21 16:42 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-21 16:42 ` [pve-devel] applied: [PATCH stable-7 manager] pve7to8: enable noout before upgrade Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621161948.116285-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal