From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention
Date: Wed, 21 Jun 2023 17:02:00 +0200 [thread overview]
Message-ID: <20230621150201.100421-1-f.ebner@proxmox.com> (raw)
It just talks about the default behavior since PVE 7. It's rather
confusing to mention this, because the behavior doesn't change anymore
in PVE 8.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Intended for both master and stable-7.
PVE/CLI/pve7to8.pm | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 6b51e98e..87dc1dc3 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -608,8 +608,6 @@ sub check_backup_retention_settings {
my $pass = 1;
- my $node_has_retention;
-
my $maxfiles_msg = "parameter 'maxfiles' is deprecated with PVE 7.x and will be removed in a " .
"future version, use 'prune-backups' instead.";
@@ -626,8 +624,6 @@ sub check_backup_retention_settings {
$pass = 0;
log_warn("$fn - $maxfiles_msg");
}
-
- $node_has_retention = defined($param->{maxfiles}) || defined($param->{'prune-backups'});
};
if (my $err = $@) {
$pass = 0;
@@ -643,15 +639,6 @@ sub check_backup_retention_settings {
$pass = 0;
log_warn("storage '$storeid' - $maxfiles_msg");
}
-
- next if !$scfg->{content}->{backup};
- next if defined($scfg->{maxfiles}) || defined($scfg->{'prune-backups'});
- next if $node_has_retention;
-
- log_info(
- "storage '$storeid' - no backup retention settings defined - by default, since PVE 7.0"
- ." it will no longer keep only the last backup, but all backups"
- );
}
eval {
--
2.39.2
next reply other threads:[~2023-06-21 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 15:02 Fiona Ebner [this message]
2023-06-21 15:02 ` [pve-devel] [PATCH stable-7 manager 2/2] pve7to8: avoid confusing warning about required setting 'storage' for vzdump Fiona Ebner
2023-06-21 16:16 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-21 16:16 ` [pve-devel] applied: [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621150201.100421-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.