all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 3/5] ui: pci/usb map edit: improve new host mappings dialog
Date: Wed, 21 Jun 2023 09:41:40 +0200	[thread overview]
Message-ID: <20230621074142.742461-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230621074142.742461-1-d.csapak@proxmox.com>

by disallowing nodes to be selected where a mapping already exists

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* dont' disable autoselect, the first allowed node will be selected
* for usb mappings too
 www/manager6/window/PCIMapEdit.js | 9 ++++++++-
 www/manager6/window/USBMapEdit.js | 4 ++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/www/manager6/window/PCIMapEdit.js b/www/manager6/window/PCIMapEdit.js
index 8c1a95e3..f243362b 100644
--- a/www/manager6/window/PCIMapEdit.js
+++ b/www/manager6/window/PCIMapEdit.js
@@ -58,7 +58,13 @@ Ext.define('PVE.window.PCIMapEditWindow', {
 	    let me = this;
 	    let view = me.getView();
 	    me.originalMap = [...values.map];
-	    values.map = PVE.Parser.filterPropertyStringList(values.map, (e) => e.node === view.nodename);
+	    let configuredNodes = [];
+	    values.map = PVE.Parser.filterPropertyStringList(values.map, (e) => {
+		configuredNodes.push(e.node);
+		return e.node === view.nodename;
+	    });
+
+	    me.lookup('nodeselector').disallowedNodes = configuredNodes;
 	    return values;
 	},
 
@@ -203,6 +209,7 @@ Ext.define('PVE.window.PCIMapEditWindow', {
 		    name: 'node',
 		    editConfig: {
 			xtype: 'pveNodeSelector',
+			reference: 'nodeselector',
 		    },
 		    cbind: {
 			editable: '{!nodename}',
diff --git a/www/manager6/window/USBMapEdit.js b/www/manager6/window/USBMapEdit.js
index 80f8e785..f36f1d03 100644
--- a/www/manager6/window/USBMapEdit.js
+++ b/www/manager6/window/USBMapEdit.js
@@ -71,13 +71,16 @@ Ext.define('PVE.window.USBMapEditWindow', {
 	    let me = this;
 	    let view = me.getView();
 	    me.originalMap = [...values.map];
+	    let configuredNodes = [];
 	    PVE.Parser.filterPropertyStringList(values.map, (e) => {
+		configuredNodes.push(e.node);
 		if (e.node === view.nodename) {
 		    values = e;
 		}
 		return false;
 	    });
 
+	    me.lookup('nodeselector').disallowedNodes = configuredNodes;
 	    if (values.path) {
 		values.usb = 'path';
 	    }
@@ -145,6 +148,7 @@ Ext.define('PVE.window.USBMapEditWindow', {
 		    name: 'node',
 		    editConfig: {
 			xtype: 'pveNodeSelector',
+			reference: 'nodeselector',
 		    },
 		    cbind: {
 			editable: '{!nodename}',
-- 
2.30.2





  parent reply	other threads:[~2023-06-21  7:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  7:41 [pve-devel] [PATCH manager v2 1/5] ui: resource map tree: make 'ok' status clearer Dominik Csapak
2023-06-21  7:41 ` [pve-devel] [PATCH manager v2 2/5] ui: pci map edit: reintroduce warnings checks Dominik Csapak
2023-06-21  7:41 ` Dominik Csapak [this message]
2023-06-21  7:41 ` [pve-devel] [PATCH manager v2 4/5] ui: pci map edit: fix typos in warnings and use gettexts Dominik Csapak
2023-06-21  7:41 ` [pve-devel] [PATCH manager v2 5/5] ui: pci/usb mapping: rework mapping panel for better user experience Dominik Csapak
2023-06-21  8:07 ` [pve-devel] applied: [PATCH manager v2 1/5] ui: resource map tree: make 'ok' status clearer Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621074142.742461-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal