all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 7/7] remove trailing spaces and colons from labels
Date: Tue, 20 Jun 2023 11:16:10 +0200	[thread overview]
Message-ID: <20230620091610.68835-8-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20230620091610.68835-1-m.sandoval@proxmox.com>

For consistency sake, all colons and trailing spaces in labels were
removed, this matches other panels such as the password and
country/timezone panels.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/proxinstall b/proxinstall
index 86922e2..b2c214b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1559,7 +1559,7 @@ sub create_ipconf_view {
     }
 
     my $devicebox = Gtk3::Box->new('horizontal', 0);
-    my $label = Gtk3::Label->new("Management Interface:");
+    my $label = Gtk3::Label->new("Management Interface");
     $label->set_size_request(150, -1);
     $label->set_xalign(1.0);
 
@@ -1569,7 +1569,7 @@ sub create_ipconf_view {
     my $fqdn = Proxmox::Install::Config::get_fqdn();
     my $hn = $fqdn // "$iso_env->{product}." . ($ipconf->{domain} // "example.invalid");
 
-    my ($hostlabel, $hostentry) = create_text_input($hn, 'Hostname (FQDN):');
+    my ($hostlabel, $hostentry) = create_text_input($hn, 'Hostname (FQDN)');
     $grid->attach($hostlabel, 0, 1, 1, 1);
     $grid->attach($hostentry, 1, 1, 1, 1);
 
@@ -1580,7 +1580,7 @@ sub create_ipconf_view {
 
     my $gwlabel;
     ($gwlabel, $ipconf_entry_gw) =
-	create_text_input($gateway, 'Gateway:');
+	create_text_input($gateway, 'Gateway');
 
     $grid->attach($gwlabel, 0, 3, 1, 1);
     $grid->attach($ipconf_entry_gw, 1, 3, 1, 1);
@@ -1589,7 +1589,7 @@ sub create_ipconf_view {
 
     my $dns_label;
     ($dns_label, $ipconf_entry_dns) =
-	create_text_input($dnsserver, 'DNS Server:');
+	create_text_input($dnsserver, 'DNS Server');
 
     $grid->attach($dns_label, 0, 4, 1, 1);
     $grid->attach($ipconf_entry_dns, 1, 4, 1, 1);
@@ -2452,7 +2452,7 @@ sub create_hdoption_view {
 	    $target_hd_label->set_text("Target: $filesys ");
 	    $options_stack->set_visible_child_name("raiddisk");
 	} else {
-	    $target_hd_label->set_text("Target Harddisk: ");
+	    $target_hd_label->set_text("Target Harddisk");
 	}
 
 	if ($raid) {
@@ -2665,7 +2665,7 @@ sub create_hdsel_view {
     my ($disk, $devname, $size, $model, $logical_bsize) = $cached_disks->[0]->@*;
     $target_hd = $devname if !defined($target_hd);
 
-    $target_hd_label = Gtk3::Label->new("Target Harddisk: ");
+    $target_hd_label = Gtk3::Label->new("Target Harddisk");
     $hbox->pack_start($target_hd_label, 0, 0, 0);
 
     $target_hd_combo = Gtk3::ComboBoxText->new();
-- 
2.39.2





      parent reply	other threads:[~2023-06-20  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  9:16 [pve-devel] [PATCH installer 0/7] use gtk grids when possible Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 1/7] move create_basic_grid subroutine definition up Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 2/7] use basic grid in the network panel Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 3/7] expand ip address Gtk3::Entry Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 4/7] use basic grid in password panel Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 5/7] use basic grid in country/timezone panel Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 6/7] change margins in create_basic_grid Maximiliano Sandoval
2023-06-20  9:16 ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620091610.68835-8-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal