From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 3/5] ui: multi pci selector: indent functions multifunction devices
Date: Mon, 19 Jun 2023 11:13:32 +0200 [thread overview]
Message-ID: <20230619091334.1715659-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230619091334.1715659-1-d.csapak@proxmox.com>
when there is more than one function for a device, indent the individual
functions. This sets them visually apart from the 'pass all through as
one' entry
We have to use a html entity here, as extjs trims the normal whitespace.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/MultiPCISelector.js | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/MultiPCISelector.js b/www/manager6/form/MultiPCISelector.js
index 97241bb0..e1ef691a 100644
--- a/www/manager6/form/MultiPCISelector.js
+++ b/www/manager6/form/MultiPCISelector.js
@@ -128,16 +128,17 @@ Ext.define('PVE.form.MultiPCISelector', {
let slots = {};
records.forEach((rec) => {
let slotname = rec.data.id.slice(0, -2); // remove function
- rec.set('slot', slotname);
if (slots[slotname] !== undefined) {
slots[slotname].count++;
+ rec.set('slot', slots[slotname]);
return;
}
-
slots[slotname] = {
count: 1,
};
+ rec.set('slot', slots[slotname]);
+
if (rec.data.id.endsWith('.0')) {
slots[slotname].device = rec.data;
}
@@ -213,6 +214,12 @@ Ext.define('PVE.form.MultiPCISelector', {
{
header: 'ID',
dataIndex: 'id',
+ renderer: function(value, _md, rec) {
+ if (value.match(/\.[0-9a-f]/i) && rec.data.slot?.count > 1) {
+ return ` ${value}`;
+ }
+ return value;
+ },
width: 150,
},
{
--
2.30.2
next prev parent reply other threads:[~2023-06-19 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 9:13 [pve-devel] [PATCH manager 1/5] ui: fix pci map selector status column Dominik Csapak
2023-06-19 9:13 ` [pve-devel] [PATCH manager 2/5] ui: multi pci selector: reset the selection properly on nodename change Dominik Csapak
2023-06-19 9:13 ` Dominik Csapak [this message]
2023-06-19 9:13 ` [pve-devel] [PATCH manager 4/5] ui: pci map edit: make top fields more clear Dominik Csapak
2023-06-19 9:13 ` [pve-devel] [PATCH manager 5/5] ui: resource mappings: remove border and add resize handle Dominik Csapak
2023-06-19 11:27 ` [pve-devel] applied-series: [PATCH manager 1/5] ui: fix pci map selector status column Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619091334.1715659-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal