[pve-devel] [PATCH] smartmontools.default: add `-q never` to smartd_opts

[pve-devel] [PATCH] smartmontools.default: add `-q never` to smartd_opts

[Stoiko Ivanov]

smartmontools has the option to run as 'notify' type systemd.service
(see `smartd(8)` in bookworm and later), and debian-upstream uses
this.
If a system has no monitorable disks (observed in a HP DL380g8, where
smartd does not seem to work by default with the the smart-array
controller with a RAID1 configured) the smartmontools.service fails
because smartd exits with 17.

Adding `-q nodev0`, which should cause the exit not to be considered a
failure does not work either, because type=notify does not expect the
daemon to exit (or the daemon exits before notifying systemd)

Tested by installing a version with this patch on the HP DL380g8
mentioned above, additionally inside a VM running PVE and a workstation
upgraded to the latest 8.0 beta.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 debian/smartmontools.default | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/smartmontools.default b/debian/smartmontools.default
index 6a8a6e2..ed6c78a 100644
--- a/debian/smartmontools.default
+++ b/debian/smartmontools.default
@@ -5,5 +5,5 @@
 # Not needed (and not recommended) if the device is monitored by smartd
 #enable_smart="/dev/hda /dev/hdb"
 
-# uncomment to pass additional options to smartd on startup
-#smartd_opts="--interval=1800"
+# to pass additional options to smartd on startup add them space separated
+smartd_opts="-q never"
-- 
2.30.2

[pve-devel] applied: [PATCH] smartmontools.default: add `-q never` to smartd_opts

[Thomas Lamprecht]

Am 16/06/2023 um 14:22 schrieb Stoiko Ivanov:
> smartmontools has the option to run as 'notify' type systemd.service
> (see `smartd(8)` in bookworm and later), and debian-upstream uses
> this.
> If a system has no monitorable disks (observed in a HP DL380g8, where
> smartd does not seem to work by default with the the smart-array
> controller with a RAID1 configured) the smartmontools.service fails
> because smartd exits with 17.
> 
> Adding `-q nodev0`, which should cause the exit not to be considered a
> failure does not work either, because type=notify does not expect the
> daemon to exit (or the daemon exits before notifying systemd)
> 
> Tested by installing a version with this patch on the HP DL380g8
> mentioned above, additionally inside a VM running PVE and a workstation
> upgraded to the latest 8.0 beta.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  debian/smartmontools.default | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!