From: Alexander Zeidler <a.zeidler@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Alexander Zeidler <a.zeidler@proxmox.com>
Subject: [pve-devel] [PATCH v2 manager/container/guest-common 0/4] fix #3069: add pbs-entries-max to vzdump.conf
Date: Thu, 15 Jun 2023 16:14:41 +0200 [thread overview]
Message-ID: <20230615141445.188274-1-a.zeidler@proxmox.com> (raw)
Users reported[1] about failing backups to PBS when having a large amount of files in a directory.
proxmox-backup-client has already 'entries-max' implemented. The default value is also a kind of DOS prevention feature. Overriding this parameter needs at least 'Sys.Modify' permissions.
This patch series makes the new optional parameter 'pbs-entries-max' available in vzdump and vzdump.conf.
[1] https://bugzilla.proxmox.com/show_bug.cgi?id=3069
Changes from v1:
Incorporated Fiona's comments. For details see patch emails.
pve-manager:
Alexander Zeidler (2):
api: backup: refactor backup permission check
api: backup: add 'pbs-entries-max' to permission check & config
PVE/API2/Backup.pm | 2 +-
configs/vzdump.conf | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
pve-container:
Alexander Zeidler (1):
add 'pbs-entries-max' parameter
src/PVE/VZDump/LXC.pm | 5 +++++
1 file changed, 5 insertions(+)
pve-guest-common:
Alexander Zeidler (1):
vzdump: schema: add 'pbs-entries-max' property
src/PVE/VZDump/Common.pm | 10 ++++++++++
1 file changed, 10 insertions(+)
--
2.39.2
next reply other threads:[~2023-06-15 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 14:14 Alexander Zeidler [this message]
2023-06-15 14:14 ` [pve-devel] [PATCH v2 manager 1/4] api: backup: refactor backup permission check Alexander Zeidler
2023-07-07 12:53 ` Fiona Ebner
2023-07-27 8:42 ` [pve-devel] applied: " Fabian Grünbichler
2023-06-15 14:14 ` [pve-devel] [PATCH v2 manager 2/4] api: backup: add 'pbs-entries-max' to permission check & config Alexander Zeidler
2023-07-07 12:53 ` Fiona Ebner
2023-06-15 14:14 ` [pve-devel] [PATCH v2 container 3/4]: add 'pbs-entries-max' parameter Alexander Zeidler
2023-07-07 12:59 ` Fiona Ebner
2023-06-15 14:14 ` [pve-devel] [PATCH v2 guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property Alexander Zeidler
2023-07-07 13:13 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615141445.188274-1-a.zeidler@proxmox.com \
--to=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.