all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] fix #4739: ui: add group column in user list
@ 2023-06-14 12:31 Dominik Csapak
  2023-06-14 14:18 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2023-06-14 12:31 UTC (permalink / raw)
  To: pve-devel

to get a fast overview in which groups each user is.

for that we need to add the 'full=1' parameter.

this only tokens/groups to the api call, but we have that info in the
backend after parsing the config anyway, so it should not be very
costly.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/UserView.js       | 6 ++++++
 www/manager6/form/UserSelector.js | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js
index 957ff682..39ca15ec 100644
--- a/www/manager6/dc/UserView.js
+++ b/www/manager6/dc/UserView.js
@@ -217,6 +217,12 @@ Ext.define('PVE.dc.UserView', {
 		    },
 		    dataIndex: 'keys',
 		},
+		{
+		    header: gettext('Groups'),
+		    dataIndex: 'groups',
+		    renderer: Ext.htmlEncode,
+		    flex: 1,
+		},
 		{
 		    header: gettext('Comment'),
 		    sortable: false,
diff --git a/www/manager6/form/UserSelector.js b/www/manager6/form/UserSelector.js
index 8fb31d7e..5af30441 100644
--- a/www/manager6/form/UserSelector.js
+++ b/www/manager6/form/UserSelector.js
@@ -7,7 +7,7 @@ Ext.define('pmx-users', {
     ],
     proxy: {
 	type: 'proxmox',
-	url: "/api2/json/access/users",
+	url: "/api2/json/access/users?full=1",
     },
     idProperty: 'userid',
 });
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] fix #4739: ui: add group column in user list
  2023-06-14 12:31 [pve-devel] [PATCH manager] fix #4739: ui: add group column in user list Dominik Csapak
@ 2023-06-14 14:18 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-14 14:18 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

Am 14/06/2023 um 14:31 schrieb Dominik Csapak:
> to get a fast overview in which groups each user is.
> 
> for that we need to add the 'full=1' parameter.
> 
> this only tokens/groups to the api call, but we have that info in the
> backend after parsing the config anyway, so it should not be very
> costly.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/dc/UserView.js       | 6 ++++++
>  www/manager6/form/UserSelector.js | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
>

applied, with rewording the commit message, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-14 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 12:31 [pve-devel] [PATCH manager] fix #4739: ui: add group column in user list Dominik Csapak
2023-06-14 14:18 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal