From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 2/2] zones: status: add a special message if vnet is not generated
Date: Mon, 12 Jun 2023 19:43:47 +0200 [thread overview]
Message-ID: <20230612174347.1598994-3-aderumier@odiso.com> (raw)
In-Reply-To: <20230612174347.1598994-1-aderumier@odiso.com>
if vnet has not been generated (this should never happend)
warn the user to check if "source /etc/network/interfaces.d/sdn'
exist
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
src/PVE/Network/SDN/Zones.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm
index 7d70e49..e26e21f 100644
--- a/src/PVE/Network/SDN/Zones.pm
+++ b/src/PVE/Network/SDN/Zones.pm
@@ -267,7 +267,11 @@ sub status {
my $err_msg = $plugin->status($plugin_config, $zone, $id, $vnet, $status);
if (@{$err_msg} > 0) {
$vnet_status->{$id}->{status} = 'error';
- $vnet_status->{$id}->{statusmsg} = join(',', @{$err_msg});
+ if (grep(/^missing ${id}$/, @$err_msg)) {
+ $vnet_status->{$id}->{statusmsg} = "vnet $id is not generated. Do you have included 'source /etc/network/interfaces.d/sdn' ?";
+ } else {
+ $vnet_status->{$id}->{statusmsg} = join(',', @{$err_msg});
+ }
$zone_status->{$zone}->{status} = 'error';
}
}
--
2.30.2
next prev parent reply other threads:[~2023-06-12 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 17:43 [pve-devel] [PATCH pve-network 0/2] fix zones status Alexandre Derumier
2023-06-12 17:43 ` [pve-devel] [PATCH pve-network 1/2] zones: fix status Alexandre Derumier
2023-06-13 11:13 ` [pve-devel] applied: " Fabian Grünbichler
2023-06-12 17:43 ` Alexandre Derumier [this message]
2023-06-13 11:21 ` [pve-devel] [PATCH pve-network 2/2] zones: status: add a special message if vnet is not generated Fabian Grünbichler
2023-06-13 11:40 ` Fabian Grünbichler
2023-06-14 19:41 ` DERUMIER, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612174347.1598994-3-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.