From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 2/2] apt repositories: avoid potential type error in classifyOrigin helper
Date: Fri, 9 Jun 2023 16:16:26 +0200 [thread overview]
Message-ID: <20230609141626.4766-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230609141626.4766-1-f.ebner@proxmox.com>
with undefined (or otherwise falsy) argument.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/node/APTRepositories.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 47c0a2c..016118e 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -406,6 +406,7 @@ Ext.define('Proxmox.node.APTRepositories', {
product: 'Proxmox VE', // default
classifyOrigin: function(origin) {
+ origin ||= '';
if (origin.match(/^\s*Proxmox\s*$/i)) {
return 'Proxmox';
} else if (origin.match(/^\s*Debian\s*(:?Backports)?$/i)) {
--
2.39.2
next prev parent reply other threads:[~2023-06-09 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 14:16 [pve-devel] [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text Fiona Ebner
2023-06-09 14:16 ` Fiona Ebner [this message]
2023-06-09 15:35 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609141626.4766-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.