From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/2] fix #517: api: allow resizing qcow2 disk with snapshots
Date: Tue, 30 May 2023 15:52:03 +0200 [thread overview]
Message-ID: <20230530135207.87705-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230530135207.87705-1-f.ebner@proxmox.com>
Support for this was added in QEMU 5.1 by commit 7fa140abf6 ("qcow2:
Allow resize of images with internal snapshots").
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/API2/Qemu.pm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 587bb222..a80eefc9 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -4719,9 +4719,6 @@ __PACKAGE__->register_method({
my (undef, undef, undef, undef, undef, undef, $format) =
PVE::Storage::parse_volname($storecfg, $drive->{file});
- die "can't resize volume: $disk if snapshot exists\n"
- if %{$conf->{snapshots}} && $format eq 'qcow2';
-
my $volid = $drive->{file};
die "disk '$disk' has no associated volume\n" if !$volid;
--
2.39.2
next prev parent reply other threads:[~2023-05-30 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 13:52 [pve-devel] [PATCH-SERIES qemu-server/manager/container] resize endpoint improvements Fiona Ebner
2023-05-30 13:52 ` Fiona Ebner [this message]
2023-05-30 13:52 ` [pve-devel] [PATCH qemu-server 2/2] fix #2315: api: have resize endpoint spawn a worker task Fiona Ebner
2023-05-30 13:52 ` [pve-devel] [PATCH manager 1/1] ui: override description for resize task Fiona Ebner
2023-05-30 13:52 ` [pve-devel] [PATCH container 1/2] api: resize: drop error that can never apply Fiona Ebner
2023-05-30 13:52 ` [pve-devel] [PATCH container 2/2] api: resize: fork before locking Fiona Ebner
2023-06-07 17:29 ` [pve-devel] applied-series: [PATCH-SERIES qemu-server/manager/container] resize endpoint improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530135207.87705-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.